Giter VIP home page Giter VIP logo

Comments (7)

eliocamp avatar eliocamp commented on August 11, 2024

This is not intended. Thanks for reporting. It seems I'm being foiled by unexpected modify by reference.

from ggnewscale.

eliocamp avatar eliocamp commented on August 11, 2024

All should be good now.

library(ggplot2)
library(ggnewscale)
topography <- expand.grid(x = 1:nrow(volcano), y = 1:ncol(volcano))
topography$z <- c(volcano)

## create two equivalent ggplot objects
p0 <- ggplot(mapping = aes(x, y)) + geom_contour(data = topography, aes(z = z, color = stat(level))) + scale_color_viridis_c(option = "D")
p <- ggplot(mapping = aes(x, y)) + geom_contour(data = topography, aes(z = z, color = stat(level))) + scale_color_viridis_c(option = "D")

p + new_scale_colour()
#> Registered S3 method overwritten by 'ggedit':
#>   method from   
#>   +.gg   ggplot2

all.equal(p, p0)
#> [1] TRUE

Created on 2019-07-15 by the reprex package (v0.3.0)

from ggnewscale.

raymondben avatar raymondben commented on August 11, 2024

Super! Thanks

from ggnewscale.

eliocamp avatar eliocamp commented on August 11, 2024

Thanks to you for reporting the bug :D

from ggnewscale.

eliocamp avatar eliocamp commented on August 11, 2024

The fix for this bug introduced more serious bugs (see #14), so I'm reverting the fix and looking for other options. Sorry, @raymondben!

from ggnewscale.

eliocamp avatar eliocamp commented on August 11, 2024

Now it's got to be fixed.

from ggnewscale.

raymondben avatar raymondben commented on August 11, 2024

Heheh. If a job's worth doing, it's worth doing twice, yeah? Thanks again.

from ggnewscale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.