Do not require ex_doc about cldr_currencies HOT 9 CLOSED

Sorry everyone, I don't know how this got back in master branch but I have re-fixed and am re-publishing. Apologies for the inconvenience.

from cldr_currencies.

Apologies for the inconvenience. I have published version 2.9.1 that makes ex_doc an optional dependency.

The issue I have been seeing in my release process is strange issues relating to earmark crashing when I pin ex_doc to only some Mix environments. Making ex_doc optional seems to remove that issue and also remove it as a hard dependency for you. Therefore optimistic that this new version removes the requirement to dependency gymnastics on your end.

Will leave the issue open for a while in case it doesn't resolve the issue for some other reason.

from cldr_currencies.

You made a typo :)

{:ex_doc, "~> 0.18", optiobal: true, runtime: false},

from cldr_currencies.

Thanks for the catch and sorry for messing that up. I republished with the same version so if you reinstall the dependency I think it should be ok now.

from cldr_currencies.

Thanks, this seems to work just fine.

from cldr_currencies.

Hi @kipcole9, I think this issue has resurfaced with the new 2.10.0 version. I don't think your change to make ex_doc optional made it into the mainline, looking at https://github.com/elixir-cldr/cldr_currencies/blob/master/mix.exs#L43

I'm getting a fairly identical error to @tcitworld original issue, an override on my side solves it for now

from cldr_currencies.

It was added back in 6f5d0b4

from cldr_currencies.

Published ex_cldr_currencies version 2.10.1 to have ex_doc only configured for the :dev and :release mix environments and set to runtime: false and optional: true just to make sure.

Sorry for the inconvenience, I don't know how this regressed. I will find a way to add a test for the ex_doc configuration so this doesn't happen again.

from cldr_currencies.

Amazing, thanks for the quick turn-around

from cldr_currencies.