Giter VIP home page Giter VIP logo

Comments (4)

fishcakez avatar fishcakez commented on August 19, 2024

This looks like a bug in cached_statement implementation in postgrex. Quickly looking at the code suggests the savepoint isn't created on prepare when mode is :savepoint and query is in the cache.

from ecto_sql.

josevalim avatar josevalim commented on August 19, 2024

@fishcakez good catch. What do you think we should do in this case? create the savepoint or avoid the rolling back to the savepoint that does not exist?

from ecto_sql.

fishcakez avatar fishcakez commented on August 19, 2024

@josevalim when we execute we need to create a savepoint, so we can't avoid it. I think it is much simpler code wise if we create it in the handle_prepare callback.

from ecto_sql.

josevalim avatar josevalim commented on August 19, 2024

Fixed in elixir-ecto/postgrex#416.

from ecto_sql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.