Good work! about protobuf HOT 12 CLOSED

@karlseguin Glad to hear that! Please let me know if there's any problem for you. I'll try to fix the problems ASAP 😬

from protobuf.

Hi Tony. I'm also very interested in using this instead of exprotobuf. We do need oneofs though. Do you have an estimate of when you expect them to be ready for use?

from protobuf.

@meadoch1 I'm working on it now! I hope to finish it within these two days. Will ping you when it's done.😄

from protobuf.

Wow, that's great news. Thanks! Since you're doing maps and oneof can I assume it's proto3 compatible otherwise too?

from protobuf.

@meadoch1 Yes. But I think I'd better add more tests about compatibility :)

from protobuf.

👍

from protobuf.

@tony612 how is the progress on oneof coming?

from protobuf.

from protobuf.

That's good news. I'll pull it and give it a try soon. Thanks!

from protobuf.

@meadoch1 OK. I can release a new version if you think there're no serious issues. It is worth mentioning that the usage for oneof is a little different:

TestMsg.Oneof.new(first: {:a, 42})

In this example, :first is the oneof field, :a is the actual field and 42 is the actual value. This can be refered from the tests, like https://github.com/tony612/protobuf-elixir/blame/master/test/protobuf/protoc/integration_test.exs#L22. Please give some feedback about this design. It's not easy to decide how to implement oneof in dynamic type language like Elixir.

I'll add documents after my holiday ends these days.

from protobuf.

I'll see what I can shake out of it, but it may be a couple of weeks before I get it vetted well. I'll reply back here with results.

from protobuf.

I've gotten a chance to work with the library some at this point, porting an app from exprotobuf to your library. I found using protobuf-elixir to be good and love that it validates on encoding. That solves several problems that we've been encountering. The Oneof syntax is no more unwieldy than in exprotobuf and I think simply reflects that Oneofs are more complex than simply nested messages. Unfortunately I don't have a good thought on how to structure them differently.

I'd think it's good and worth cutting a new version to make official. Thanks for all your work on this.

from protobuf.