Giter VIP home page Giter VIP logo

Comments (5)

tony612 avatar tony612 commented on May 23, 2024 1

@zentetsukenz Yes. And I've moved descriptor.pb.ex and plugin.pb.ex to lib/google/protobuf. So you can pull master and add the timestamp proto.

from protobuf.

tony612 avatar tony612 commented on May 23, 2024

Thank you. But I prefer not. This lib is the implementation of protobuf, I don't think adding Google's proto definitions in this lib is a good idea.

from protobuf.

tony612 avatar tony612 commented on May 23, 2024

By looking into other official implementations(https://developers.google.com/protocol-buffers/docs/reference/overview), I think it's ok to include it in this lib. Could you place the proto file and generated Elixir file in lib/google/protobuf?

from protobuf.

zentetsukenz avatar zentetsukenz commented on May 23, 2024

@tony612 Sure! I will do open a PR for this. However, I'm still unsure that I understand your solution. This is what I'm currently understand. Create a new file in lib/google/protobuf/. Named it timeout.pb.ex and put the code snippet above into this file.

I'm not sure about this because I saw that there are many google file descriptor definition in lib/protobuf/protoc/descriptor.pb.ex. So, I think I would have to do things similar to this by putting the file in lib/protobuf/protoc folder.

Thank you in advance.

from protobuf.

zentetsukenz avatar zentetsukenz commented on May 23, 2024

@tony612 PR #25 opened, please have a look when you have time. Thank you for your consideration.

from protobuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.