Discuss codifying elli_middleware behaviour about elli HOT 9 CLOSED

Perhaps the functions above should be optional callbacks in elli_handler instead.

from elli.

When erlang started in interactive mode and Elli is just another dependency (i.e. elli_prometheus tests), you can't just set {callback, elli_middleware} because it won't pass valid_callback since module isn't loaded yet. So either we should force module loading before/in valid_callback or don't call it at all.

This of course applies to 3d part middlewares too.

from elli.

Which module isn't loaded, elli_middleware or e.g. elli_prometheus?

from elli.

elli_middleware! Basically in interactive mode erlang won't load module until it called or its metadata asked.

from elli.

https://github.com/elli-lib/elli_prometheus/pull/11/files#diff-ccb26da865ea3c50c86dd4ae91942d2fR22

from elli.

I made the change from parsing Mod:module_info/1 to erlang:function_exported/3. Should we revert back?

from elli.

yeah!

from elli.

Done.

from elli.

Awesome, thanks!

from elli.