Comments (5)
Ha! There was a big discussion thread about this on a previous mailing list.
There
was a lot of back and forth about whether the connection should or shouldn't be
closed. It's a gray area in the JDBC / JTA specs (plus probably a number of
other
J2EE specs). Different app servers behave different ways. I originally though
exactly the same way you are, but after further investigation, it's "more
common and
accepted" for consumers of a managed to connection to call close(). The
container or
transaction manager shouldn't actually close the connection, but instead should
just
"mark" it as no longer in use so that it can be closed at the end of the
transaction
scope. While it was still fuzzy as to which way to go, ultimately we decided
that we
would use iBATIS 2 as the tie breaker -- which means we decided to close the
connection.
Here's the original thread:
http://www.mail-archive.com/[email protected]/msg16138.html
I think the right thing to do here will be to create another implementation, or
perhaps a config property to not close the connection.
As for the null check... that's one of those things where I would expect a null
pointer exception. It's not an acceptable call of that method.
Cheers,
Clinton
Original comment by [email protected]
on 29 May 2010 at 2:17
from mybatis.
Original comment by [email protected]
on 29 May 2010 at 2:17
- Added labels: Version-Release3.x, Component-SqlMaps
from mybatis.
Added closeConnection property to transactionManager. For example:
{{{
<transactionManager type="MANAGED">
<property name="closeConnection" value="false"/>
</transactionManager>
}}}
Default is still true (close the connection).
Original comment by [email protected]
on 29 May 2010 at 2:54
- Changed state: Fixed
from mybatis.
Original comment by [email protected]
on 29 May 2010 at 2:59
- Added labels: Target-Release3.0.2
from mybatis.
Can you give a couple of sample configuration code for "how to make the
mybatis transaction management in EBJ3.0 contrainer" , thanks very much.
Original comment by [email protected]
on 15 Apr 2011 at 4:03
from mybatis.
Related Issues (20)
- [mybatis-spring] Mapper scanning should not rely on proprietary @Mapper annotation HOT 1
- Migrations archive unzips to "ibatis-migrations" instead of "mybatis-migrations" HOT 2
- OSGI Support HOT 4
- Remove mapper order restriction when referencing SQL fragment in another file. HOT 40
- Non-existent object id is incorrectly resolved when there is an entry with the same short name. HOT 13
- Allow applying @Transactional to types and interfaces and add a @NoTransaction attribute HOT 4
- Please prioritize issues HOT 1
- Adjust issue's status HOT 1
- Unable to get auto-generated ID with mysql using annotations HOT 1
- Mybatis-spring doesn't propagate exceptions up the stack when using batch mode HOT 17
- how to free temp tablespace allocated for a select stmt return parameter HOT 1
- rollback on BatchExecutor executes batched statements HOT 8
- resultMap doesn't support mapping of unnamed columns by index HOT 2
- mybatis3.0.3 bug in WebService ?? HOT 2
- Annotation-based and AOP-based sessions HOT 3
- Global parameter typeHandler not invoked in case of null values HOT 2
- Exception: Result Maps collection does not contain value for test.User-result HOT 2
- Handling of update counts before result sets in select HOT 8
- configure behavior when all columns values are null for some rows HOT 5
- queryForMap does not use a column as map HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mybatis.