Giter VIP home page Giter VIP logo

Comments (7)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024
And I prefer 'utf-8' to be the default rather than the platform's default 
encoding when 'script_char_set' is not specified explicitly.

Original comment by [email protected] on 18 Jun 2010 at 9:30

from mybatis.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024
Attached a patch against trunk revision 2390.

Original comment by [email protected] on 25 Aug 2010 at 3:54

Attachments:

from mybatis.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024
By the way, this is not a simple cosmetic change. Without this fix, migration 
scripts containing data in languages such as Chinese do not work and renders 
the migration tool useless in such context.

Please up the priority of this fix.

Original comment by [email protected] on 26 Apr 2011 at 5:18

from mybatis.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024
Attached a new patch against r3830.
I had to modify two existing test cases this time, but I believe the change was 
reasonable.
And with this version, the default charset is used when 'script_char_set' is 
not specified.

Thanks,
Iwao

Original comment by [email protected] on 11 Jul 2011 at 5:28

Attachments:

from mybatis.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024
Thanks for keeping this updated Iwao. 

This is indeed an encoding bug, once the File is opened with the wrong charset 
it is too late to fix it with new String(byte[], encoding)

I think it is better not to use utf-8 by default to avoid backwards 
compatibility problems.

Fixed in r3836

Original comment by eduardo.macarron on 29 Jul 2011 at 5:46

  • Changed state: Fixed
  • Added labels: Component-Migrations, Target-Release3.0.6

from mybatis.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024
Eduardo, Thank you for committing the patch!

Original comment by [email protected] on 31 Jul 2011 at 5:15

from mybatis.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024

Original comment by eduardo.macarron on 4 Apr 2012 at 10:36

  • Added labels: Version-Release3.x

from mybatis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.