Comments (4)
Original comment by Michael Markert (Bitbucket: cofi, GitHub: cofi):
@input-methods\
Didn't notice. But it broke: Typing ue
with german-postfix got me üü (double result). But b464897 seems to fix it.
@legacy\
Well then: Great that it broke :)
from evil.
Original comment by Frank Fischer (Bitbucket: lyro, GitHub: lyro):
Thanks. The function `evil-repeat-record-command' should never be called with a non-function repeat-type ... so my fix is to remove this function completely (it was legacy anyway) ;)
But I realized that repeation with input-methods did not work (anymore?). It should work in b464897 again.
from evil.
Original comment by Michael Markert (Bitbucket: cofi, GitHub: cofi):
What I meant wrt to input method: Typing any char triggered an error. Should've made this clear :(
The change seems to fix it, I don't run into the issue anymore.
For completeness sake: I changed `evil-repeat-record-command' this way:
(defun evil-repeat-record-command (&optional repeat-type)
"Calls the post-repeat-information of the current command."
;; finish repeation of current command
(let ((repeat-type (or repeat-type
(evil-repeat-type this-command t))))
- (funcall repeat-type 'post)))
+ (if repeat-type
+ (funcall repeat-type 'post))))
But since evil-repeat-type' can return nil and
repeat-type' is optional you should consider adding such a check.
from evil.
Original comment by Frank Fischer (Bitbucket: lyro, GitHub: lyro):
I'm sorry but I find this bug report really confusing and difficult to understand. I hope I fixed the bug in 8fac166. If not, please give an example of what is going wrong. Of course, you are encouraged to give hints where the bug may be, but without an example it is very hard to figure out what fails at all.
from evil.
Related Issues (20)
- How do I set a goal column in Evil? HOT 2
- How do I handle `Symbol’s function definition is void: evil-add-to-alist`? HOT 3
- Input method in search and in replace modes doesn't match the currently activated one in insert mode
- Cursor color does not persist HOT 6
- Unable to set certain variables by `:custom` in `use-package` HOT 1
- Incompatibility with package indent-bars HOT 3
- Ex command no longer completes command contain dash (-) HOT 4
- Can’t make ‘nil’ obsolete; did you forget a quote mark? HOT 2
- Arrow Keys behaves like in vi HOT 15
- missing characters when horizontal scrolling if fringe-mode off + truncate-lines + tab indentation
- evil-define-key is not restricted to the mode specified HOT 1
- Yanking to ?+ register does not work in Emacs >=29 HOT 6
- `evil-search` with `isearch` module does not respect `dired-isearch-filenames-mode` starting with Emacs 29
- Restrict adding certain buffers to jump list HOT 6
- `company-complete` results in `(evil-repeat-post-hook): (wrong-type-argument number-or-marker-p nil)`
- Missing Visual Mode command: v_g_CTRL-A HOT 3
- evil-visual-char is not inclusive when using goto-char? HOT 2
- `describe-char` doesn't work outside of evail unless `(ad-deactivate #'describe-char)` is evaluated HOT 5
- evil-mode text insertion breaks emacs text property inheritance (stickiness of text properties) HOT 5
- the global ex command (:g) doesn't take a count HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from evil.