Giter VIP home page Giter VIP logo

Comments (6)

tomdl89 avatar tomdl89 commented on May 28, 2024 1

Thanks @Hi-Angel - I can reproduce. If evil-want-fine-undo is set to t then I can't, so it does indeed look like evil is clobbering the undo info for what was typed, most likely as part of its evil-start-undo-step grouping. Will investigate when I have some time. The proliferation of marker entries looks like it's worth investigating too.

from evil.

Hi-Angel avatar Hi-Angel commented on May 28, 2024 1

Yay, cool, that works! Thanks!

from evil.

Hi-Angel avatar Hi-Angel commented on May 28, 2024

This may be a bug in Emacs, because the problem is reproduced if I bind C-/ and C-r (the latter in "normal mode") to undo-only and undo-redo directly.

However, I'd need some help in reducing this to a testcase that detaches the problem from Evil.

from evil.

Hi-Angel avatar Hi-Angel commented on May 28, 2024

Idk if relevant, but I found out that reproducing the bug leaves a marker in no buffer entry in the buffer-undo-list list.

Evil somehow causes it, that won't appear in emacs -Q. As a matter of fact, Evil leaves around a lot of marker entries while following the steps (albeit only one of them is a "no buffer"). That does not happen with emacs -Q which has only one marker.

from evil.

Hi-Angel avatar Hi-Angel commented on May 28, 2024

Thank you @tomdl89. Makes me wonder if that's somehow connected to the infamous undo-tree "unrecognized entry in undo list" error.

from evil.

tomdl89 avatar tomdl89 commented on May 28, 2024

I have evil-want-fine-undo set to t and I think that is the best solution to this problem. But I have also made a commit which does provide a fix, of sorts, without doing that: https://github.com/tomdl89/evil/tree/insert-state-undo-in-normal-state.
@Hi-Angel can you check out the branch and let me know if it works as expected? It drops you back to normal state, undoes the (entire) insert, and then puts you back into insert state. A jumping-off point, at least, hopefully.

from evil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.