Aggressive-indent-mode incompatibility about emacs-ccls HOT 14 OPEN

If you use this

(add-to-list
 'aggressive-indent-dont-indent-if
 '(and (derived-mode-p 'c++-mode)
       (null (string-match "\\([;{}]\\|\\b\\(if\\|for\\|while\\)\\b\\)"
                           (thing-at-point 'line)))))

Does it still happen?

from emacs-ccls.

The problem isn't there anymore but aggressive-indent-mode doesn't do anything either. Even if my buffer doesn't match the regex (which is hard to create because it looks like it will match anything that has parens, ifs, etc).

from emacs-ccls.

It works fine for me. Are you sure that the problem is not something else?

from emacs-ccls.

I just tried my minimal config above together with your suggestion and the problem is still there (text is still deleted). I think I forgot to enable aggresive-indent in my last reply. I used this c++ sample file

#include <stdio.h>
int main()
{
    int i, j, rows;

    printf("Enter number of rows: ");
    scanf("%d",&rows);

    for(i=1; i<=rows; ++i)
    {
	for(j=1; j<=i; ++j)
	{
	    printf("* ");
	}
	printf("\n");
    }
    return 0;
}

from emacs-ccls.

What emacs version are you running ?Also can you check if company is activated before or after aggressive-indent ?

from emacs-ccls.

I'm running the latest stable arch linux build of emacs: GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-07-05
The minimal config in op didn't have company installed, but i tried adding

(straight-use-package 'company)
(global-company-mode)

to it with the same results as my last post

from emacs-ccls.

Instead of

(global-aggressive-indent-mode)

can you try hooking up aggressive-indent-mode on c-mode-hook and c++-mode-hook?

from emacs-ccls.

That seems to make it more stable, but text is still randomly deleted if you press delete in this situation

    code
   |int var = 10;
    code

| = cursor

from emacs-ccls.

OK at least we improved something, another concern i have is that Maskray has configured ccls in wiki using 3 different hooks from you.

  :hook ((c-mode c++-mode objc-mode) .
         (lambda () (require 'ccls) (lsp)))

Can you remove from your config

(add-hook 'c-mode-hook 'lsp)
(add-hook 'c++-mode-hook 'lsp)
(add-hook 'objc-mode-hook 'lsp)

and replace it with the equivalent code of straight.el-use-package based on the code i mentioned above?

from emacs-ccls.

That's the same as

(add-hook 'c-mode-hook '(lambda () (require 'ccls) (lsp)))
(add-hook 'c++-mode-hook '(lambda () (require 'ccls) (lsp)))
(add-hook 'objc-mode-hook '(lambda () (require 'ccls) (lsp)))

which has the same problem

from emacs-ccls.

I am not sure but c-mode and c-mode-hook are not the same.
The equivalent to what i said is.

(add-hook 'c-mode '(lambda () (require 'ccls) (lsp)))
(add-hook 'c++-mode '(lambda () (require 'ccls) (lsp)))
(add-hook 'objc-mode '(lambda () (require 'ccls) (lsp)))

from emacs-ccls.

No, every mode has a hook that is run when it is enabled, so what :hook ((c-mode c++-mode objc-mode) . does is that it takes the hooks of those modes and runs whatever is after the dot when those hooks are run
What's written after (add-hook 'c-mode never executes because c-mode is just a function that inits the c-mode, not a hook

from emacs-ccls.

(setq lsp-enable-indentation nil)
(setq lsp-enable-on-type-formatting nil)
seemed to fix it for me

from emacs-ccls.

I can confirm the solution proposed from @0x00539 works.

from emacs-ccls.