Giter VIP home page Giter VIP logo

Comments (14)

Jasper-Bekkers avatar Jasper-Bekkers commented on May 26, 2024 1

from physx-rs.

maxded avatar maxded commented on May 26, 2024 1

Figured it out! Fix is on it's way rust-lang/cc-rs#572 :)

from physx-rs.

maxded avatar maxded commented on May 26, 2024 1

The latest version of cc fixes this issue!

from physx-rs.

repi avatar repi commented on May 26, 2024

@Jasper-Bekkers you were looking into this right?

from physx-rs.

VZout avatar VZout commented on May 26, 2024

Reduced to roughly 8257 chars when using -no-everything. So close yet so far...

from physx-rs.

repi avatar repi commented on May 26, 2024

@Jasper-Bekkers any further progress on this?

from physx-rs.

VZout avatar VZout commented on May 26, 2024

rust-lang/cc-rs#547 solves this.

from physx-rs.

repi avatar repi commented on May 26, 2024

Awesome!

from physx-rs.

maxded avatar maxded commented on May 26, 2024

Alright, I've been looking into this issue quite a bit this week and am majorly confused.

The error @repi shows above shouldn't actually error at all. The reason being, yes the command is 10k+ lines of code but cc spawns the command as a new process, whose command limit is 32767 characters according to this blog. I've compared the command length of that same command on a msvc -> msvc cl.exe invocation and it was also over 10k+ characters long but doesn't error.

Linking would actually fail on msvc -> Android as cc tried to link every .o file in one go, which would result in a command over 32k+ characters. When targeting msvc this was solved by using a response file but not when targeting Android. This issue I fixed by progressive linking, which has been merged in cc.

TLDR: no clue why we get this error :(

from physx-rs.

repi avatar repi commented on May 26, 2024

@maxded ouch. you are able to reproduce the error locally on Windows right though?

from physx-rs.

maxded avatar maxded commented on May 26, 2024

Yes

from physx-rs.

maxded avatar maxded commented on May 26, 2024

Would it be possible to reduce the number of include directories when compiling physx-sys itself instead of relying on a fix in cc-rs? My fix mentioned above reintroduces response files to cc-rs when they just recently got completely removed and the maintainer would prefer if they stayed removed.

from physx-rs.

Jake-Shadle avatar Jake-Shadle commented on May 26, 2024

You can try, but the way the physx code works means a lot of includes are needed.

from physx-rs.

repi avatar repi commented on May 26, 2024

Awesome!

from physx-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.