Giter VIP home page Giter VIP logo

Comments (8)

deshraj avatar deshraj commented on June 12, 2024 1

@Dev-Khant sure go for it.

from embedchain.

deshraj avatar deshraj commented on June 12, 2024 1

Yeah this seems like a reasonable approach to me as well. Please proceed with this approach.

from embedchain.

Dev-Khant avatar Dev-Khant commented on June 12, 2024

@deshraj Can I pick this up?

from embedchain.

Dev-Khant avatar Dev-Khant commented on June 12, 2024

Hi @deshraj,

Here to get data for repo, branch and for specific folder I think using get_repo function from Github library would be easier compared to the current approach of cloning the repo and then traversing the tree. For extracting specific file we can directly use get_contents.

Docs:

  1. get_repo: https://pygithub.readthedocs.io/en/latest/examples/Repository.html#get-all-of-the-contents-of-the-root-directory-of-the-repository
  2. get_contents: https://pygithub.readthedocs.io/en/latest/examples/Repository.html#get-a-specific-content-file

I have previously worked around this approach: https://github.com/Dev-Khant/Analyze-Github-Code/blob/main/LLM/scrap.py#L33

Making a change to this will only affect the query with type=="repo".
Let me know if I can move ahead with this approach.

from embedchain.

Dev-Khant avatar Dev-Khant commented on June 12, 2024

@deshraj Here do we need to store data from results because currently data variable is already getting replaced by self._get_github_repo_data. Let me know if we want to add data from results or just the content of repo.

Screenshot 2024-03-08 at 2 46 58 PM

from embedchain.

deshraj avatar deshraj commented on June 12, 2024

Ah good catch. This seems like a bug and should be fixed. Can you please fix it in your PR?

from embedchain.

Dev-Khant avatar Dev-Khant commented on June 12, 2024

Yes I can fix it. But do we have to add results to data or just the repo contents?

from embedchain.

Dev-Khant avatar Dev-Khant commented on June 12, 2024

@deshraj I have raised the PR.

from embedchain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.