Giter VIP home page Giter VIP logo

Comments (3)

ef4 avatar ef4 commented on August 26, 2024

Ah, make sense. I think we would fix this in animated-value. Currently it essentially passes items=[value] to animated-each, but when value is null we should pass items=[].

from ember-animated.

ef4 avatar ef4 commented on August 26, 2024

My apologies, but now that I think more about it, I was wrong in my comment above.

null is a valid value that you may want to render and animate.

For example:

{{#animated-value myPreference as |pref|}}
  {{#if pref}}
      Your preference is {{pref}}.
   {{else}}
      You have not chosen a preference.
   {{/if}}
{{/animated-value}}

While it would be possible to make animated-value accept its own {{else}} block, that's a complication I would rather avoid, when you can achieve the same thing as above without learning a new concept.

So instead I think we should add guards where we try to use the key property to access properties on the possibly-null value.

from ember-animated.

Cryrivers avatar Cryrivers commented on August 26, 2024

@ef4 sure, i will investigate this weekend.

from ember-animated.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.