Giter VIP home page Giter VIP logo

Comments (3)

teddyzeenny avatar teddyzeenny commented on August 18, 2024

Yes. A regexp would be more accurate. Some things to note though. In pods the module name will end with the type so we should modify the regexp to also accept modules that end with the type name (like myapp/company/model.js). I also don't think we can rely on always having only one word before the type.

The inspector currently uses class detection (DS.Model.detect) after getting the list to filter out false positives.

from ember-resolver.

gabrielgrant avatar gabrielgrant commented on August 18, 2024

Ah, interesting. I dug into the inspector code a little while trying to sort this out, but didn't catch that.

When you say you don't think we can rely on there only being one word before the type, do you mean something like myapp/models/supertype/subtype.js or myapp/multi-named-pod/model.js or myapp/my-pod/sub-pod/model.js or something else entirely?

Assuming both those pods layouts are valid, I think RegExp('^[a-zA-Z0-9-_]+\/(.*)\/' + type + '$') should work. I'd probably be inclined to keep the detection of pods and non-pods separate, just to avoid descending too far into the depths of regex hell.

from ember-resolver.

stefanpenner avatar stefanpenner commented on August 18, 2024

as of 3.0 this is now provided by ember (correctly)

from ember-resolver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.