Should we provide a config that disables some rules from `@typescript-eslint/eslint-plugin`? about eslint-plugin-ember HOT 11 OPEN

this? #2107

mmm, this might be different .
But it wil be eager later. Because scope is passes directly, right?

from eslint-plugin-ember.

mmm, this might be different .

yeah, that PR adds rules to a config, which I don't think we should do.

I imagine the TS config should end up looking like this:

{
  // this is the exact same as what's in the README
  files: ['**/*.gts'],
  parser: 'ember-eslint-parser',
  plugins: ['ember'],
  extends: [
    'eslint:recommended',
    // hopefully this either adds the rules to the config (so that 2107 isn't needed)
    // or we give up on legacy configs and only recommend flat config
    'plugin:@typescript-eslint/recommended',
    'plugin:ember/recommended',
     // this would detect if @typescript-eslint is present, 
     // and make sure no-use-before-define is turned off
    'plugin:ember/recommended-gts', 
  ],
},

from eslint-plugin-ember.

I think the error is correct though.
it will be compiled to something like

Foo =  precompileTemplate(`...`,  {
  scope: [Bar]
})

from eslint-plugin-ember.

I think it was pretty clear that they will not change plugin:@typescript-eslint/recommended behaviour. (Lets discuss this part in #2107)

from eslint-plugin-ember.

it wilz be compiled to something like

nay, it's

scope: () => ({ Bar })

from eslint-plugin-ember.

it wilz be compiled to something like

nay, it's

scope: () => ({ Bar })

hmm, i took another look, you are right:)

But it looks like the rule isn't looking that exactly anyway:
eslint playground

from eslint-plugin-ember.

ah! so the eslint rule is wrong!

from eslint-plugin-ember.

I looks like that's actually the behaviour it intended to do:

This rule will warn when it encounters a reference to an identifier that has not yet been declared.

https://eslint.org/docs/latest/rules/no-use-before-define#rule-details

from eslint-plugin-ember.

yeah -- but .. it's safe!

from eslint-plugin-ember.

i think this can be closed then? as the rule does work correctly as per its own definition

from eslint-plugin-ember.

It works incorrectly for how we need it to tho 🤔

from eslint-plugin-ember.