Giter VIP home page Giter VIP logo

Comments (8)

victor-stone avatar victor-stone commented on May 12, 2024

More info: Even if I hack the FB server to use req.url (instead of req.path) then this transition abort() in the underlying router lib forces an HTTP Status 500

To recreate:

curl http://localhost:3000/somepath?foo=bar

from ember-cli-fastboot.

tomdale avatar tomdale commented on May 12, 2024

Thanks, I'll look into this.

from ember-cli-fastboot.

scottmessinger avatar scottmessinger commented on May 12, 2024

I can confirm this bug. Anything I can do to help fix it?

from ember-cli-fastboot.

chancancode avatar chancancode commented on May 12, 2024

the transition bug should be fixed on canary, but fastboot needs to be updated to consume the new API; I'll send a PR this weekend!

from ember-cli-fastboot.

victor-stone avatar victor-stone commented on May 12, 2024

this is great news (!) - any updates?

from ember-cli-fastboot.

tomdale avatar tomdale commented on May 12, 2024

@chancancode Any update on this?

from ember-cli-fastboot.

chancancode avatar chancancode commented on May 12, 2024

If I am reading myself correctly, it should already be fixed now?

from ember-cli-fastboot.

chancancode avatar chancancode commented on May 12, 2024

I see. I was referring to the "redirect bug", which is indeed fixed in ember now. I think the line @victor-stone was pointing to (https://github.com/ember-fastboot/ember-fastboot-server/blob/5b89456cee90d10785978e2736742a2f1ce7fda7/lib/server.js#L69) still needs to be changed to use req.url?

from ember-cli-fastboot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.