Comments (2)
In regards to ICU Message syntax what would you expect The number is: {nonexistent}
to look like?
That said I did a little research and found that per the ECMAScript specs that the value is anything as it will be coerced to a number (defaulting with undefined).
I didn't look up the other formats. But it seems to me that it is safe to assume value
is not a required parameter. It may be weird to have the format convert to NaN
or something but I presume that is what is expected?
from ember-intl.
I did a little more research:
Spec | Expectation | Interpretation |
---|---|---|
11.5.5 DateTime Format Functions | If date is not provided or is undefined, then Let x be ! Call(%Date.now%, undefined). Else, Let x be ? ToNumber(date). | Do not assert value |
15.5.2 Number Format Functions | If value is not provided, let value be undefined. Let x be ? ToNumeric(value). | Do not assert value |
13.5.3 FormatList | list (which must be a List of String values) | Must assert value |
Since format-message uses the above internal implementations their expectations should be the same (i.e. do not assert). Also since lists are the only one I found that does need an assertion and that the ICU message syntax does not provide for lists it is reasonable that the format-message also should not assert values.
I am uncertain about the utility of allowing dynamic messages for format-message in app code instead perhaps using some alternative pattern that guarantees the existence of the value passed in (like hard coded strings or constants).
As for format-list the ICU guides recommend its use outside the message formatting:
Format the parameters separately (recommended)
You can format the parameter as you need before calling MessageFormat, and then passing the resulting string as a parameter to MessageFormat.
This offers maximum control, and is preferred to using custom format objects (see below).
~ https://unicode-org.github.io/icu/userguide/format_parse/messages/index#format-the-parameters-separately-recommended
Which I interpret that we should to the following with lists:
from ember-intl.
Related Issues (20)
- When will there be another release? HOT 1
- Type issues from Registry HOT 6
- Type issues from -format-base.d.ts HOT 1
- bump typescript peer dependency to 5 HOT 3
- trailingZeroDisplay not working HOT 4
- FORMAT_ERROR when using the `Intl.RelativeTimeFormat` polyfill with `v6.0.0` of ember-intl HOT 3
- Double `intl.d.ts` cause type errors HOT 8
- Unexpected locale `en-us` after upgrade to ember-intl v6 HOT 6
- A simple, autogenerated integration test fails for a component using a translation in ember-intl 6.1.2 HOT 6
- Bundle size regression in v6.2.0 HOT 3
- Merge this into formatjs HOT 3
- Incompatible with native `ember-source` types HOT 5
- `allowEmpty` class property not respected in v6.3.1 HOT 1
- Extending helpers like FormatDate has braking changes between v6.2.2 and v6.3.0+ HOT 5
- Basic usage results in: You attempted to update `_locale` [...] infinite revalidation bugs, and performance issues, and is not supported. HOT 4
- How to use `publicOnly: true` in Embroider apps HOT 13
- v6 - Error on valid use of `many`: message cannot be parsed: Unknown plural category: many HOT 1
- Deleted
- Plans for v7 release
- Memory leak regression after upgrading to `>= 6.3.0` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-intl.