Comments (5)
rwjblue
commented on June 28, 2024
2
@richard-viney - Ya, I'm working on it. I hope to have a patch release for 1.x out with the deprecation fixed, and also to release 2.0.0 with the TS refactor.
from ember-modifier.
simonihmig
commented on June 28, 2024
Given that Ember's current beta and canary releases already issue deprecations for the use of setSourceDestroying(), it would be nice get this sooner than later!
Especially as this causes some failing addon tests (set up to fail on deprecations) for me 😉
from ember-modifier.
rwjblue
commented on June 28, 2024
Good point @simonihmig!
from ember-modifier.
jordpo
commented on June 28, 2024
I'm also seeing the setSourceDestroying deprecations now on [email protected].
from ember-modifier.
richard-viney
commented on June 28, 2024
The setSourceDestroying deprecations seen when using Glimmer components were addressed in [email protected] and @glimmer/[email protected], however these ones coming from ember-modifier are still with us.
Is anyone already looking at this? If not, I could potentially look at doing a PR this week.
from ember-modifier.
Related Issues (20)
- Invalid modifier manager compatibility specified HOT 3
- No way to listen for changes to `this.element` HOT 3
- Plan for v4 release HOT 9
- Deprecation for missing options is backwards HOT 1
- [3.2.0]+ `state.teardown is not a function` HOT 2
- 3.2+: Class-based modifiers don't call `modify`? HOT 6
- `[email protected]` erroneously reporting deprecations HOT 8
- Use Volta in CI config
- Functional `{{modifier}}` destructor being called after initializer HOT 1
- Be more explicit in v3 -> v4 modifier() deprecation warning
- ember-modifier v3.2.3+ crashes during build on parsing syntax (Missing semicolon) HOT 11
- Ember modifier broke in each loop HOT 6
- Switch to Volta action HOT 1
- 4.0 Migration docs not mentioning the need for e-auto-import in dependencies HOT 7
- 3.2+ Cleanup function is not called within specific component HOT 7
- Options (and eager) seems to have disappeared in v4.0.0 HOT 2
- Strange Bug `_ember_modifier__WEBPACK_IMPORTED_MODULE_1__.setModifierManager is not a function`
- `eager` option for functional modifiers is undocumented outside migration guide HOT 2
- Created a basic modifier that just does a console.log for now, and I get an "Error: Compile Error test-me is not a modifier: Helpers may not be used in the element form." HOT 1
- Cannot read properties of undefined (reading 'manager') HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-modifier.