Can't set templateName of custom bodyViewClass of ModalPane about ember-bootstrap HOT 5 OPEN

This is actually an issue with the removal of the default container in Ember-Core. Sadly the error coming up is a bit obtuse.

Explanation is here https://gist.github.com/stefanpenner/5627411.

There are a couple of ways of fixing it, you can pass the default container into the popup function if you have access to it from where you are calling popup.

I personally have overriden the popup method, but I have worries that it wouldn't work universally so I never contributed it back to ember-bootstrap.

Bootstrap.ModalPane.reopenClass({
  popup: function(options) {
    var modalPane, rootElement;
    if (!options) options = {};
    modalPane = this.create(options);

    if (!modalPane.container && modalPane.get("controller")) {
      modalPane.container = modalPane.get("controller").container;
    }

    rootElement = get(this, 'rootElement');
    modalPane.appendTo(rootElement);
    return modalPane;
  }
});

This is definitely something that should be fixed in ember-bootstrap, I'll have a think about it.

from ember-bootstrap.

Ah, interesting issue. It would have taken a while for me to figure that out on my own, thanks for the help!

from ember-bootstrap.

Note: To use the fix you posted the ModalPane has to be passed a controller somehow. I ended up passing it in hash I gave to the popup method.

from ember-bootstrap.

Any movement on this? Is ember-bootstrap going to incorporate a fix?

from ember-bootstrap.

We should indeed.

from ember-bootstrap.