Giter VIP home page Giter VIP logo

Comments (7)

buschtoens avatar buschtoens commented on May 31, 2024

Ember._modifierManagerCapabilities was only added 16 days ago:

https://github.com/emberjs/ember.js/blame/4ae6015c558d42a570342996f9c7769c2246dfcf/packages/ember/index.js#L531

Previously it was a typo: _modifierManagerCapabilties

Updating to ember-source@^3.13.0-beta.3 resolves this as it contains the fix.

from ember-render-modifiers.

rwjblue avatar rwjblue commented on May 31, 2024

Ya, but ember-polyfills/ember-modifier-manager-polyfill#10 specifically added support in the polyfill for consistently importing import { capabilities } from '@ember/modifier'; (e.g. the new name is always present even before 3.13.0-beta.3).

from ember-render-modifiers.

rwjblue avatar rwjblue commented on May 31, 2024

[email protected] directly depends on [email protected] (here) so we should have the most recent version with that fix in it...

@gossi - Can you share a bit of info:

  • yarn list ember-modifier-manager-polyfill
  • your ember-source version

from ember-render-modifiers.

gossi avatar gossi commented on May 31, 2024
$ yarn list ember-modifier-manager-polyfill ember-source
yarn list v1.17.3
warning Filtering by arguments is deprecated. Please use the pattern option instead.
├─ [email protected]
└─ [email protected]
✨  Done in 0.71s.
"ember-source": "https://s3.amazonaws.com/builds.emberjs.com/canary/shas/755ea5dbe65d91e0d650707da740aa6900d0a755.tgz"

from ember-render-modifiers.

rwjblue avatar rwjblue commented on May 31, 2024

Ahh, so I think you need to update your canary SHA. The polyfill uses semver.gte('3.13.0-beta.3') to decide what to do (RE: setting up Ember. _modifierManagerCapabilities) but your version is 3.14.0 (canary) which is "greater" than 3.13.0-beta.3. Unfortunately, your canary SHA predates the fix for Ember. _modifierManagerCapabilities so the polyfill decides "you have the fix", but in reality you don't.

There really isn't much we can do here for this AFAICT, I'd suggest updating your canary SHA (npx ember-source-channel-url canary -w).

from ember-render-modifiers.

gossi avatar gossi commented on May 31, 2024

That's true, updated the SHA this morning (wo/ even reading it). I love it when things magically work :)

from ember-render-modifiers.

rwjblue avatar rwjblue commented on May 31, 2024

OK, sorry for the troubles here @gossi. Going to go ahead and close this one.

from ember-render-modifiers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.