Comments (8)
I think a second render
call should properly tear down the first one first. There seems to be no downside to that, and it will Just Work as expected.
from ember-test-helpers.
#147 added the ability to call clearRender
as needed, but did not add guards or automatically call clearRender
when multiple this.render
calls are made.
In theory I am fine with either, but kinda lean towards automatically calling clearRender
on any subsequent this.render
calls (since multiple this.render
calls "works" today).
from ember-test-helpers.
Thanks for reporting!
@ef4 / @dgeb - Thoughts on this?
from ember-test-helpers.
FWIW it's perfectly possible to have two tests invoke this very same component.
It seems questionable to me if there's value in mixing both render types into one test or if it wasn't a better idea to separate them by default in the component-test blueprint.
from ember-test-helpers.
@dschmidt - Yes, the default blueprint is definitely odd at best (having both block and blockless in the same test). We should definitely fix that (perhaps @trabus recalls why we went this specific way).
from ember-test-helpers.
I believe the intent was actually to show both forms for the consumer to pick one or the other, we obviously weren't clear about it.
from ember-test-helpers.
👍 this should be fixed.
Cleanup failures are really annoying to debug because it effectively leaks state into subsequent tests.
from ember-test-helpers.
Should be resolved by #155.
from ember-test-helpers.
Related Issues (20)
- Setup context fails when using ember-data v4 and a custom resolver
- Allow `waitUntil` to accept a callback that returns a promise HOT 1
- Types missing from version 3 HOT 4
- Anomalies in current published version compared to previous versions HOT 5
- Allow Ember v5
- needed infra maintainence HOT 1
- 3.2.0 Missing `lookup` and `register` on `Owner` type definition HOT 8
- How to refresh current visiting page in Ember Test?
- Remove old compatibility code HOT 1
- TypeScript error with `Owner` interface HOT 3
- New app failing to start HOT 2
- Update to ember-cli-babel@8+ to fix a json5 vulnerability HOT 3
- Proposal: Allow context to teardown and setup repeatedly in a test HOT 1
- Read "maxlength" attribute instead of "maxLength" in "-guard-for-maxlength.ts" HOT 2
- Update `git clone` url in CONTRIBUTING.md file HOT 2
- Conflicting rule in `"resolutions"` in root `package.json` and addon's `package.json` for `rimraf` causing failure. HOT 2
- Re-enable testing on 5.10+ once emberjs/ember.js#20724 fixed HOT 1
- Module not found: Error: `@ember/test-helpers` is trying to import from `@ember/-internals` but that is not one of its explicit dependencies HOT 5
- ember-try scenarios failed after installing @ember/[email protected] HOT 11
- @ember/test-helpers v4 suggests itself to be in dependencies even when only used for test-support files HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-test-helpers.