Add waitFor(selector) test helper about rfcs HOT 7 CLOSED

I like this. I'd suggest making the API this.waitFor({ selector: ... }) or even just this.wait({ selector: ... }) as we will probably want to wait on other things in the future, e.g. ajax, routing, etc.

We could also do this.waitForSelector if we want to continue supporting the context argument...

from rfcs.

@mmun You could also do type sniffing, if arg is string else treat as object, but that makes the API a bit fragile.

from rfcs.

this type of sniffing (in our tests are work at-least) often result in quite brittle tests. Largely, because now a failure isn't attached to the action triggering, rather a lengthy timeout of sorts.

Maybe i just have PTSD, and it is ok when used in some scenarios, but I just felt i should mention my experience.

from rfcs.

I also wanted to mention that 'this.wait' is almost certainly going to be provided by the new testing harness proposed in another RFC.

from rfcs.

Would recommend also including an additional timeout parameter in msecs.

from rfcs.

Also of interest:
http://discuss.emberjs.com/t/waituntil-async-helper-feedback/9444

from rfcs.

waitFor (and waitUntil) is a public API since around Ember 3.0. Thanks for this discussion, it absolutely influenced that implementation.

from rfcs.