Giter VIP home page Giter VIP logo

Comments (11)

dgeb avatar dgeb commented on May 15, 2024 1

Note: To make the Final Comment Period official, we need to announce it here and on Twitter, so we're restarting the period now.


This RFC is now entering a "final comment period". This period is intended to focus the community's attention for a final round of consideration and feedback before an RFC is merged.

Please carefully consider the implications of this RFC and how it will affect your Ember projects. Now would be a good time to re-raise any concerns that you feel haven't been fully addressed.

If no significant blockers are raised by October 7, we plan to merge this RFC and make plans for its implementation. :shipit:

from rfcs.

rwjblue avatar rwjblue commented on May 15, 2024 1

Closing this issue in favor of emberjs/ember.js#13663

from rfcs.

rwjblue avatar rwjblue commented on May 15, 2024

The implementation that I have seen was a gist from @stefanpenner, maybe he still has it handy?

from rfcs.

trentmwillis avatar trentmwillis commented on May 15, 2024

There was also this in the original PR (seems to have gone largely unnoticed): emberjs/ember.js#9383 (comment)

from rfcs.

stefanpenner avatar stefanpenner commented on May 15, 2024

https://gist.github.com/stefanpenner/0baadd08d0733f9e8ae0#file-pause-test-js although that example uses a getter, which may or may not be of value.

from rfcs.

trentmwillis avatar trentmwillis commented on May 15, 2024

Would a PR adding this into core be welcome? If so, I'll pull it together with some tests

from rfcs.

mixonic avatar mixonic commented on May 15, 2024

I'm not certain how well making a change and resuming will work in practice, but this would be pretty low hanging fruit to add behind a feature flag and experiment with. I'd be +1 to see a PR. :-D

from rfcs.

rwjblue avatar rwjblue commented on May 15, 2024

Agree

from rfcs.

trentmwillis avatar trentmwillis commented on May 15, 2024

I'm not certain how well making a change and resuming will work in practice

True, but at the very least this will enable the ability to use more than one pauseTest to walk through an Acceptance test (which means I can stop using andThen(() => { debugger; })).

from rfcs.

stefanpenner avatar stefanpenner commented on May 15, 2024

I'm not certain how well making a change and resuming will work in practice,

its less about resuming after a change, and more about being able to emulate debugger, without blocking the entire thread of execution. I can say with confidence this pause/resume works really well with acceptance tests. So +1 from me.

from rfcs.

rwjblue avatar rwjblue commented on May 15, 2024

FCP didn't drum up any additional feedback, and we are still 👍 on the feature. Lets do it!

from rfcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.