Comments (4)
I think people get scare of low-level RFCs, sometimes π
having better error / deprecation reporting would be a huge win tho
from rfcs.
out of curiosity, is this related to #778
from rfcs.
The main reason I opened the issue is not related to that PR β I was trying to revive emberjs/ember.js#19069 by @bekzod, however I realized a lot of what made it hard/tricky at the time is to still keep some of the existing private "view utils" functions (getChildViews
, etc) working. These functions were originally intended for Ember Inspector, but it doesn't use them anymore since we switched to the newer captureRenderTree()
API.
Those functions are not really useful anymore since they only work for classic Ember.Component
subclasses. So I set out to deprecate them first. Since there is not a lot of urgency (which is why it took so long to get my attention β sorry! there just always were something more pressing/immediate), I figured it would be easier to remove these APIs (after the next LTS) together with the view registry (which is what the original PR tried to do), so we could delete everything in one go.
However, usually when we deprecate something we also need to offer an alternative. In this case, captureRenderTree()
would be the direct replacement. However, captureRenderTree()
is also private, and generally we don't want to direct people to using private APIs. In this case, since it is going from a private API to another private API, and it's unclear that anyone actually uses these (and did not already independently decide to switch to captureRenderTree()
on their own), it seems okay. But I figured I should make it clear that if anyone is actually using them are aware of this and we could work together on stabilizing this API.
Now, as for the #778, it's at least tangentially related, in that if captureRenderTree()
is a private API, it does not logically make a lot of sense to RFC changes to it β either it is a private API and we are free to make the changes as needed, or that the RFC would also have to propose to stabilize it and make it public. Since the #778 seems to be motivated by Ember Inspector use cases, I think the latter is probably fine, but nevertheless this is a perfectly good venue to discuss those changes even if we don't end up needing to formally merge it.
As for the proposal in #778 itself, initially I had the same questions as @rwjblue which he asked on the thread, and I think I am still not super clear on it after re-reading it. This is already getting super long, so I'll try the rest another time and reply on the other PR directly.
from rfcs.
@chancancode do you think this is worth an RFC? There doesnβt seem to be much uptake here.
from rfcs.
Related Issues (20)
- NVP todos
- Deprecate all of Ember Classic HOT 16
- Build-time configuration of index.html HOT 3
- Deprecate support for Travis CI HOT 6
- Deprecate `ember-mocha`? HOT 2
- Deprecate `ember-export-application-global` addon? HOT 4
- Run Prettier separately in `app` blueprint HOT 9
- Deprecate `app.import`
- Thoughts on this more ergonomic way to wire up the owner + destroyable association? HOT 2
- Explore "official" pod deprecation HOT 19
- {{else}} should render a value rather than be a control-flow keyword. HOT 5
- new primitive: transition, similar to modifiers, except they block certain render events HOT 2
- Numbers in PR titles affect automation
- Asset import spec RFC HOT 2
- Implement import spec RFC HOT 1
- Replacing `moduleName` in template meta HOT 11
- Simplified imports for common built-in modules HOT 2
- Pre-RFC: Add `aria-current` attribute to Ember's `LinkTo` component HOT 1
- Whitespace handling for `<template>` tag HOT 4
- Add LICENSE
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rfcs.