Giter VIP home page Giter VIP logo

Comments (3)

nevinera avatar nevinera commented on August 24, 2024

I guess the comment was too strong? I meant that the finish hook executes after the subprocess terminates, regardless of its termination state. An ensure would mean that if you raised an exception from your fault hook (for example), the finish hook would still execute.

I can see how the comment might imply that, but it would be unexpected behavior otherwise - I'll change the comment.

from iso_latte.

nevinera avatar nevinera commented on August 24, 2024

I don't actually see a strong reason to handle it one way or the other - if you have a good argument that the finish callback should execute even if one of the others raises, I'll consider changing that.

from iso_latte.

nevinera avatar nevinera commented on August 24, 2024

Did not mean to reopen >.<

from iso_latte.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.