Comments (3)
I will definitely limit Node
to and (:) and Relationship
to or (|) when instantiated with lists(set, Tuple) of strings, but I do think that allowing the user to write incorrect (for now maybe?) logical operators for Label
s is fine. I actually wouldn’t be able to control it without either deep object inspection during init or creating NodeLabel
etc objects.
Pypher allows users to write incorrect Cypher all over the place and to check here would be a little inconsistent. There could definitely be a layer on top of it that could guarantee “correctness” that would be a hefty project though
from pypher.
Great catch.l, I need more scrutinization like this as I’m fairly new to Cypher/Neo4j. Thanks.
I think that a potential solution is two fold. First the Entity
would be updated to use actual Label
objects for label representations. Second would be to update that Label
class to allow for ‘and’ or ‘or’ chaining (with Relationship
objects only allow for or)
With these two updates one could potentially write something like:
p.relationship(labels=Label(‘Person’) | Label(‘Animal’))
# or
p.relationship(labels=(‘Person’, ‘Animal’))
Both would work the same under the hood. I’ll have to test that interface later
(Excuse the typos I’m on my phone)
from pypher.
Yes I thought the same myself.
But I think Pypher would beneficiate from it only if Neo4j adds the possibility to match nodes with OR'ed labels, and/or allow rels to have more than one type.
Currently we can only do AND for node labels, and OR for rel types. So implementing __and__
/ __or__
in a Label
class might be a bit overpowered, since under the hood only AND will be used for nodes and only OR will be used for rels. Besides, users might get it wrong and think they can do complex logic like Label('Pokémon') & (Label('Fire') | Label('Thunder'))
from pypher.
Related Issues (20)
- function in rhs of attribute setting? HOT 3
- None in Python and NULL in Pypher inconsistency? HOT 4
- != Operator should output <> HOT 3
- Rexp parameterization (Injection Attack Risk) HOT 6
- Cannot set "list" in as property value HOT 2
- Unwind example HOT 12
- Custom class functions HOT 2
- Howto do WHERE HOT 2
- WHERE START WITH do not quote the string HOT 2
- Change `min_hops` and `max_hops` semantics HOT 2
- missing aggregate functions HOT 3
- Handling a list of dictionaries HOT 1
- Problem with And operator HOT 2
- Support for union and call HOT 3
- .`len` prefix and suffix when constructing pypher query in Python Console HOT 3
- Dynamic Variable Names HOT 10
- Pypher behaves strangely in Pycharm Debug mode HOT 4
- Quoting label names HOT 3
- Neo.ClientError.Statement.ParameterMissing HOT 5
- IN statement doesn't produce correct output when combined with partial statement returning a list HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypher.