Giter VIP home page Giter VIP logo

Comments (3)

emehrkay avatar emehrkay commented on July 20, 2024 1

I will definitely limit Node to and (:) and Relationship to or (|) when instantiated with lists(set, Tuple) of strings, but I do think that allowing the user to write incorrect (for now maybe?) logical operators for Labels is fine. I actually wouldn’t be able to control it without either deep object inspection during init or creating NodeLabel etc objects.

Pypher allows users to write incorrect Cypher all over the place and to check here would be a little inconsistent. There could definitely be a layer on top of it that could guarantee “correctness” that would be a hefty project though

from pypher.

emehrkay avatar emehrkay commented on July 20, 2024

Great catch.l, I need more scrutinization like this as I’m fairly new to Cypher/Neo4j. Thanks.

I think that a potential solution is two fold. First the Entity would be updated to use actual Label objects for label representations. Second would be to update that Label class to allow for ‘and’ or ‘or’ chaining (with Relationship objects only allow for or)

With these two updates one could potentially write something like:

p.relationship(labels=Label(‘Person’) | Label(‘Animal’))

# or
p.relationship(labels=(‘Person’, ‘Animal’))

Both would work the same under the hood. I’ll have to test that interface later

(Excuse the typos I’m on my phone)

from pypher.

pawamoy avatar pawamoy commented on July 20, 2024

Yes I thought the same myself.

But I think Pypher would beneficiate from it only if Neo4j adds the possibility to match nodes with OR'ed labels, and/or allow rels to have more than one type.

Currently we can only do AND for node labels, and OR for rel types. So implementing __and__ / __or__ in a Label class might be a bit overpowered, since under the hood only AND will be used for nodes and only OR will be used for rels. Besides, users might get it wrong and think they can do complex logic like Label('Pokémon') & (Label('Fire') | Label('Thunder'))

from pypher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.