Giter VIP home page Giter VIP logo

Comments (5)

Emiliano-Bucci avatar Emiliano-Bucci commented on July 19, 2024

@chakafasano88 Hi, thanks for using the library and for the feedback, it's very appreciated :) I'll take a look and i'll back to you asap.

from react-spring-carousel-js.

chakafasano88 avatar chakafasano88 commented on July 19, 2024

@chakafasano88 Hi, thanks for using the library and for the feedback, it's very appreciated :) I'll take a look and i'll back to you asap.

Thank you! I could be using the functionality incorrectly. If I log getIsDragging() like this:

useListenToCustomEvent('onSlideStartChange', ({ nextItem }) => console.log('onSlideStartChange', getIsDragging()))
useListenToCustomEvent('onSlideChange', ({ nextItem }) => console.log('onSlideChange', getIsDragging()))

It will log true for onSlideStartChange and false for onSlideChange which is expected.

However, I am triggering state changes inside onSlideStartChange and I have noticed a
different issue where only one hook fires and others don't. If I remove the state change and just console log the events, they fire correctly.

The context of why I am using getIsDragging: I need to disable pointer events onSlideStartChange. I'm currently using an image viewer, and need to prevent that from being triggered i dragging is true

from react-spring-carousel-js.

chakafasano88 avatar chakafasano88 commented on July 19, 2024

@chakafasano88 Hi, thanks for using the library and for the feedback, it's very appreciated :) I'll take a look and i'll back to you asap.

I was using this incorrectly.... according to your GitHub documentation:

The following options and API can be both extracted from the main hook or from the own Carousel Context (that can be imported and used inside any component rendered inside the Carousel 😏)

I'm using useContext now inside the carousel and everything behaves accordingly.

from react-spring-carousel-js.

Emiliano-Bucci avatar Emiliano-Bucci commented on July 19, 2024

@chakafasano88 Great! Still, could you please explain me better this:

However, I am triggering state changes inside onSlideStartChange and I have noticed a
different issue where only one hook fires and others don't. If I remove the state change and just console log the events, they fire correctly.

from react-spring-carousel-js.

Emiliano-Bucci avatar Emiliano-Bucci commented on July 19, 2024

@chakafasano88 I've just released a small update - 1.2.0 which fix the issues you've spotted when doing some state update in the same component when the carouselFragment is used. While I strongly suggest moving the carousel component logic (for example to update his styles) inside the component (just for performance reasons), you can now correctly use it and events will fire correctly.

As a last point, I've also introduced a small improvement in the use of the context, please read here -> https://github.com/Emiliano-Bucci/react-spring-carousel-js/releases/tag/1.2.0.

I'll close the issue; if you need any other help, don't hesitate to reach me out!

from react-spring-carousel-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.