Comments (5)
Hi!
RepaintSignal
is not meant to be shared between threads (which would require Sync
), instead it is meant to be cloned (as you do) and then moved to the other thread (requiring just Send
). You are almost there with your code, you just lack a move
:
let thread = std::thread::spawn(move || {
repaint_signal.request_repaint();
});
That should work!
from egui.
Thanks for getting back to me 😄
I tried adding the move as you suggested but that didn't seem to fix the problem.
The error message that cargo spits out seemed to say that Arc
requires both Send
and Sync
to be implemented for the type it contains.
This seems to agree with the source for Arc that I found in the rust-doc
#[stable(feature = "rust1", since = "1.0.0")]
unsafe impl<T: ?Sized + Sync + Send> Send for Arc<T> {}
#[stable(feature = "rust1", since = "1.0.0")]
unsafe impl<T: ?Sized + Sync + Send> Sync for Arc<T> {}
I don't understand enough about the internals of rust to be even remotely confident that I didn't make an unrelated mistake or messed up my build environment somehow so please let me know if I've gone wrong somewhere.
I've also attached the error message and the file I used to generate it so you can let me know if I'm interpreting the output correctly.
error[E0277]: `dyn RepaintSignal` cannot be shared between threads safely
--> src\main.rs:12:22
|
12 | let thread = std::thread::spawn(move || {
| ^^^^^^^^^^^^^^^^^^ `dyn RepaintSignal` cannot be shared between threads safely
|
::: C:\Users\micro\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib/rustlib/src/rust\library\std\src\thread\mod.rs:607:8
|
607 | F: Send + 'static,
| ---- required by this bound in `spawn`
|
= help: the trait `Sync` is not implemented for `dyn RepaintSignal`
= note: required because of the requirements on the impl of `Send` for `Arc<dyn RepaintSignal>`
= note: required because it appears within the type `[closure@src\main.rs:12:41: 14:10]`
error: aborting due to previous error
use egui::{app::IntegrationContext, CtxRef};
struct App {}
impl egui::app::App for App {
fn name(&self) -> &str {
"Name"
}
fn ui(&mut self, ctx: &CtxRef, integration_context: &mut IntegrationContext) {
let repaint_signal = integration_context.repaint_signal.clone();
let thread = std::thread::spawn(move || {
repaint_signal.request_repaint();
});
thread.join();
}
}
fn main() {
egui_glium::run(Box::new(App {}))
}
from egui.
You are of course correct! I will come with a fix shortly. And thanks for your report!
from egui.
You should now be able to continue if you add the following patch to your Cargo.toml
:
[patch.crates-io]
egui = { git = "https://github.com/emilk/egui", rev = "958fc2753aef7e35b615a13c54324860ee7f1427" } # 2020-12-27
egui_glium = { git = "https://github.com/emilk/egui", rev = "958fc2753aef7e35b615a13c54324860ee7f1427" } # 2020-12-27
egui_web = { git = "https://github.com/emilk/egui", rev = "958fc2753aef7e35b615a13c54324860ee7f1427" } # 2020-12-27
Good luck!
from egui.
Great! Thanks for the help 😁
from egui.
Related Issues (20)
- `with_always_on_top` causes window to display incorrectly when window size is equal to screen size HOT 12
- Displaying a JPEG image does not work with `image` crate version higher than 0.24 HOT 2
- Using the user agents capabilities for loading images on web
- `ctx.input(|i| i.focused)` always gets `false` for the first few frames
- `with_position` method of ViewportBuilder does not seem to work on wayland
- Better tooltip size management
- Error: WinitEventLoop(NotSupported(NotSupportedError))
- `Style` feature to have label truncate by default HOT 1
- Allow returning errors from eframe app creator
- `SidePanel` frame leaks into `BottomPanel` HOT 3
- Dependency fails to build on nightly
- How to avoid the CMD window pop up when running on Windows? HOT 2
- Allow for manual placement of the canvas element
- Add function to request a repaint to WebRunner
- Improve compile times of `eframe`
- [IME] Can't input CompositionEnd only characters because of checking ccursor.index and ime_cursor.index HOT 2
- Gif Support
- Custom light & dark themes on system theme change HOT 1
- Add a User-Agent header to HTTP image loader HOT 5
- Dithering in Fragment Shader HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from egui.