Comments (3)
Hey!
While I agree there's a need to test .whl, I'm not sure using a build.django_component
package is the way to go, as it's far from any packaging standard.
I believe tox can already use a wheel for its tests (it's currently using sdist):
[testenv]
package = wheel
wheel_build_env = .pkg
The issue here is that even if the wheel is installed in tox venvs, it is shadowed by the source code, as the package is a the top level.
After checking the pytest docs around import modes and their recommended best practices, the best solution would be to use the src
layout. This way, no more issues of the installed package being shadowed by the source files, and no need for a custom solution.
To go further for wheel testing, check-wheel-contents
can be used.
It's included in this handy Github Action: https://github.com/hynek/build-and-inspect-python-package
Running it locally, we see that there is already an error in the wheels, that ship a tests.components
module.
from django-components.
@EmilStenstrom, sorry for delay (tax submission week). @GabDug's suggestion is great, and @GabDug's thanks for taking this over 🚀
from django-components.
@JuroOravec You OK with @GabDug's suggestion here? Looks good to me.
from django-components.
Related Issues (20)
- Auto-reload server when saving component file
- Allow dynamic slots and fills HOT 1
- Template caching isn't working HOT 1
- Allow different apps to have different settings HOT 1
- Invalid block tag ... 'component'. Did you forget to register or load this tag? error HOT 20
- Warnings (probably errors) when building documentation HOT 3
- Allow dynamic components HOT 5
- feat: React-like render functions (or functional components) and CachedTemplate HOT 3
- Use variables in JS / CSS and caching thereof HOT 15
- Release 0.93 did not trigger documentation build HOT 6
- Hook into the render process to allow to modify the rendered content HOT 1
- RequestContext not populated with context processors on async request HOT 4
- First class support for HTML fragments HOT 9
- Support for AlpineJS in slots HOT 3
- Broken link in documentation HOT 2
- Docs not deployed to gh-CDN HOT 5
- Crazy idea: Auto-convert RadixUI from JSX to django-components with LLM? HOT 3
- Unexpected behaviour of `ComponentDependencyMiddleware` in combination with `as_view` usage HOT 3
- 0.100 breaks string based BASE_DIR HOT 3
- 0.100: TypeError: the 'package' argument is required to perform a relative import HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-components.