Giter VIP home page Giter VIP logo

Comments (3)

GabDug avatar GabDug commented on September 26, 2024 1

Hey!

While I agree there's a need to test .whl, I'm not sure using a build.django_component package is the way to go, as it's far from any packaging standard.

I believe tox can already use a wheel for its tests (it's currently using sdist):

[testenv]
package = wheel
wheel_build_env = .pkg

The issue here is that even if the wheel is installed in tox venvs, it is shadowed by the source code, as the package is a the top level.

After checking the pytest docs around import modes and their recommended best practices, the best solution would be to use the src layout. This way, no more issues of the installed package being shadowed by the source files, and no need for a custom solution.

To go further for wheel testing, check-wheel-contents can be used.
It's included in this handy Github Action: https://github.com/hynek/build-and-inspect-python-package

Running it locally, we see that there is already an error in the wheels, that ship a tests.components module.

from django-components.

JuroOravec avatar JuroOravec commented on September 26, 2024 1

@EmilStenstrom, sorry for delay (tax submission week). @GabDug's suggestion is great, and @GabDug's thanks for taking this over 🚀

from django-components.

EmilStenstrom avatar EmilStenstrom commented on September 26, 2024

@JuroOravec You OK with @GabDug's suggestion here? Looks good to me.

from django-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.