Giter VIP home page Giter VIP logo

Comments (10)

tapanther avatar tapanther commented on June 8, 2024 1

I think italics alone for "supported but not recommended" is prolly good enough. I agree the extra symbol gets a bit messy. But looks good otherwise!

Arbitrary cutoff above some number (13-15 seems reasonable, to include things like Werewolf and roll-n-writes) is prolly reasonable.

from mybgg.

EmilStenstrom avatar EmilStenstrom commented on June 8, 2024

Hi! Sorry for the late reply.

Yes, I'm using the community voted player counts. That means the number is not "The intended number of players from the manufacturer is X" but "This game with good with X players". Are the votes wrong with Small Railroad Empires?

from mybgg.

tapanther avatar tapanther commented on June 8, 2024

from mybgg.

tapanther avatar tapanther commented on June 8, 2024

I went through my games to look for missing 1P games, the following are also not shown as 1P games (I didn't look for missing 2P or higher counts though, but I feel like I have some that don't show up for player counts I expect)

If you need more examples I can cross-correlate 2P games too.

from mybgg.

EmilStenstrom avatar EmilStenstrom commented on June 8, 2024

Thanks for the examples. It makes sense to go with the official numbers. And maybe just mark the version that are recommended by the community, then the user can make an informed decision.

If you are able to submit a PR, I'd happily accept it!

from mybgg.

tapanther avatar tapanther commented on June 8, 2024

Sadly my new job has more restrictions and rules to contribute to projects, I haven't yet taken the time to go through it all. If there's not a quick fix you can add ( I'm really hoping its of the form getUserRecommendedCount() -> getBGGUserCount(), ) I'll start going through the approval process.

from mybgg.

boglesby03 avatar boglesby03 commented on June 8, 2024

I made an attempt at this by giving them additional player counts as "supported" with a ~.
image

It gets a little noisy on roll and writes that sometimes have 1-100 players, so I arbitrarily cut it off. I think there's probably a better way to represent this:
image

If you like it, I can pull it out and make a PR.

from mybgg.

Medwynd avatar Medwynd commented on June 8, 2024

Im not a fan of putting in the not recommended. I never use the player count information from bgg except to know the actual supported counts. I like the idea of putting the star by the recommended, even if I dont agree or care, but I would stop there.

Also instead of listing each player count individually just put the official count as "x - y", then a comma separated list of recommended counts preceeded by a star to indicate recommended

from mybgg.

tapanther avatar tapanther commented on June 8, 2024

@Medwynd The star (and circled-cross for "with expansion") should already be part of the code base (my page shows them, and I shouldn't have any local changes). If you're not seeing them, could you be out of date wrt to Emil's upstream?

As for the range, the issue comes down to search and filtering. I'd like to be able to list all my N-player games, regardless of whether it's a recommended count, and I suspect a range would not play nicely with the current "player count" dropdown filter. It could be made to work I'm sure, but that's now a larger changeset. And knowing the "supported count" is specifically the feature I want (you can of course disagree with what's desirable behavior).

from mybgg.

EmilStenstrom avatar EmilStenstrom commented on June 8, 2024

@tapanther I agree that italics should be enough.

@boglesby03 Would love to check out a PR, thanks! :)

@Medwynd I think it makes sense to include supported counts, especially with respect to games with few community votes, where the supported count is better than the community one.

from mybgg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.