TypeError in svcrack / svhelper getNonce about sipvicious HOT 3 CLOSED

might be a dupe of #44

from sipvicious.

I tried doing some tests on my end to see if this issue is reproducible, but couldn't. However I have 2 ideas that might solve this issue.

Looking at the error, it can be said that at least NoneType isn't being passed to the function. So it might be some other corrupt data is being passed along to that function (which is possible because we are using ignore when using decode('utf-8', 'ignore')). So my suggestions are:

• Use the binary bytes received from the server for regex matching and everything. Do not decode to ASCII.
• Use strict function parameter accepting datatypes, so that in this way we can better track the value being passed to the function.

Let me know what you think of this. If it sounds good, happy to make a PR.

from sipvicious.

the user who submitted this issue fixed it by doing the following:

fixed that error by simply adding "if authheader is not None:" to the svcrack.py script on string #189.
It was assuming that 401/407 response automatically means presence of authentication header, but life shows that it isn't :)

I didn't yet have time to replicate the issue and get it fixed but I'm trying to find out if this is something that we're not actually catching - so don't do anything yet @0xInfection :)

from sipvicious.