Giter VIP home page Giter VIP logo

Comments (7)

andrew-worsfold avatar andrew-worsfold commented on July 24, 2024 1

Replicated and fixed. This will be addressed in the next version.

from tailor.

andrew-worsfold avatar andrew-worsfold commented on July 24, 2024 1

True - that's what happens when I try to do things late at night! :)

I've verified that this works as expected and included it in the latest version.

Thanks again!

from tailor.

andrew-worsfold avatar andrew-worsfold commented on July 24, 2024

This should be addressed in the latest version (1.5.0). Are you able to confirm that the issue has been resolved?

from tailor.

BinaryMoon avatar BinaryMoon commented on July 24, 2024

confirmed. All working well :)

from tailor.

BinaryMoon avatar BinaryMoon commented on July 24, 2024

sorry - not confirmed - I thought this was the spinner one.

On the homepage and category pages I am seeing the 'tailor-styles-css' stylesheet still included, along with the following js:

  • /assets/js/dist/frontend.min.js
  • /assets/js/dist/vendor/slick.min.js
  • /assets/js/dist/vendor/modernizr.min.js
  • /assets/js/dist/vendor/shuffle.min.js
  • /assets/js/dist/vendor/magnific-popup.min.js

from tailor.

andrew-worsfold avatar andrew-worsfold commented on July 24, 2024

I've added an additional check (is_singular()) to ensure scripts are not loaded for archive pages. Is that working for you too?

from tailor.

BinaryMoon avatar BinaryMoon commented on July 24, 2024

Do you mean the check in includes/helpers/helpers-settings.php?

At the moment that check is saying:

    if ( ! is_singular() || tailor()->is_canvas() || tailor()->is_template_preview() ) {
        return true;
    }

But that says - if not a single page then include scripts doesn't it?

If you change it to:

    if ( ! is_singular() ) {
        return false;
    }

    if ( tailor()->is_canvas() || tailor()->is_template_preview() ) {
        return true;
    }

Then it works - at least on my local install.

from tailor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.