Giter VIP home page Giter VIP logo

Comments (6)

andrew-worsfold avatar andrew-worsfold commented on August 27, 2024 1

I agree. This has been on my list of things to do for a while. I'll switch over to the bundled version and, assuming there are no problems, have this included in the next release.

from tailor.

andrew-worsfold avatar andrew-worsfold commented on August 27, 2024

I haven't included this in version 1.5.0, as although it worked in my local environment I encountered an error with the bundled WordPress imagesLoaded script not enqueuing in a staging environment. I'm not sure, but on that server it looked like the script was bundled with masonry.js (which I'm not using).

Can imagesloaded definitely be enqueued using its own handle in the latest version of WordPress?

from tailor.

BinaryMoon avatar BinaryMoon commented on August 27, 2024

imagesloaded is a masonry dependency. I think in WordPress 4.5 they were in the same file, but in 4.6 they were separated, so if masonry is used then imagesloaded will also be enqueued.

You can see where they discuss this change here: https://core.trac.wordpress.org/ticket/32802#comment:20

from tailor.

andrew-worsfold avatar andrew-worsfold commented on August 27, 2024

As previous prior to 4.6 need to be supported, I've kept a local copy of imagesloaded around just in case. The bundled version will be used when available, but as I am not using the masonry.js script, it would be overkill to load it just for the benefit of using the bundled imagesloaded script.

Does that sound like a reasonable solution?

from tailor.

BinaryMoon avatar BinaryMoon commented on August 27, 2024

sounds good! :)

from tailor.

andrew-worsfold avatar andrew-worsfold commented on August 27, 2024

Great! That solution is in place now with Tailor 1.5.1. I'll close out this issue :)

from tailor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.