Feature Request: save() method for models about orm HOT 5 CLOSED

Instead of...

model = ModelClass()
model.string_field = 'Test' # db.StringField()
model.int_field = 5 # db.IntField()
model.bool_field = False # db.BooleanField()
await model.save()

Use this...

instance = await ModelClass.objects.create(
    string_field=...,
    int_field=...,
    bool_field=...
)

If you really need to build it up gradually you can use this pattern...

kwargs = {}
kwargs['string_field'] = 'Test'
kwargs['int_field'] = 5
kwargs['bool_field'] = False
instance = await ModelClass.objects.create(**kwargs)

Having partially populated model instances, or modifiying model instance properties directly is a problematic pattern and means that model instances don't do a good job of encapsulating valid state changes.

from orm.

Did not test if something like this will work:

class SaveableModel(Model):
    async def save(self):
        await self.objects.create(**self.fields)

from orm.

It does not work, gives typesystem.base.ValidationError: {'id': 'Must be a number.', ...

All the fields such as Integer and String are not represented as int and str. Maybe I am doing something wrong, but when I used Flask with Datastore from Flask-Security I could just use this code and it would work:

model = ModelClass()
model.string_field = 'Test' # db.StringField()
model.int_field = 5 # db.IntField()
model.bool_field = False # db.BooleanField()
model.save()

from orm.

Related: https://www.dabapps.com/blog/django-models-and-encapsulation/

from orm.

Thanks, did not know that this is problematic pattern :)

from orm.