Giter VIP home page Giter VIP logo

Comments (10)

ded avatar ded commented on August 18, 2024

this is a great idea. i think we're looking into keeping everything tucked into the "ender" key so we're not populating packages with too many non-nodish things. with that said, we want to support the ability to pass in an options hash ...

"ender": {
  main: "path/to/main.js"
  , "other": "stuff"
  , "assets": "path/to/assets"
}

from ender.

fat avatar fat commented on August 18, 2024

I was looking through the package.json spec and actually i think the best place to put this particular thing would be the directories key... so it would look like:

{
  "name": "fat",
  "version": "0.0.1",
  "authors": ["Jacob Thornton <@fat>"],
  "keywords": ["ender", "events", "event"],
  "main": "./fat.js",
  "ender": "./src/bridge.js",
  "directories": {
    "assets": "src/assets"
  }
}

from ender.

ryanflorence avatar ryanflorence commented on August 18, 2024

That looks good to me with a couple questions:

  1. Does ender just assume you want the assets directory packaged up?
  2. Is this flexible enough? What if I've got two assets directories I want packaged up?

from ender.

ded avatar ded commented on August 18, 2024

does ender just asume you want the assets directory packaged up?

perhaps..

$ ender build foo bar --noassets

or

$ ender build foo bar --includeassets

what if i've got two assets directories i want packaged up?

"directories": {
  "assets": ["src/a/assets", "src/b/assets"]
}

from ender.

fat avatar fat commented on August 18, 2024

That's a good question... i'm starting to think we should limit the options (so we don't get options crazy like git). Less to learn i think is nice... What if we just pause the build process when we encounter an assets dir? We could ask if a user wants to include the dir for a specific package and we could also ask where they would like to put it.

from ender.

ryanflorence avatar ryanflorence commented on August 18, 2024

I'd rather be scriptable and option crazy, than non-scriptable.

$ ender build foo --noassets

Would be my vote (or maybe --nobooty but I digress). Seems like if a script has assets, and ender is building, you should get the assets by default.

from ender.

ded avatar ded commented on August 18, 2024

the other question is, where do those assets go? how does one publish them? (because they won't be able to live on NPM)

from ender.

fat avatar fat commented on August 18, 2024

yeah they do/will... thats why we would use the directories key... we would just have to relocate them somewhere...

from ender.

jasonkuhrt avatar jasonkuhrt commented on August 18, 2024

Same issue here? #84

from ender.

rvagg avatar rvagg commented on August 18, 2024

ref #131

from ender.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.