Comments (3)
https://github.com/tc39/proposal-class-fields/blob/main/PRIVATE_SYNTAX_FAQ.md
Foundy.js line 52402
static #getCircleShape(distance) {
return new PIXI.Circle(0, 0, distance);
}
Think they have gone a bit more miliant with stopping us overriding!
I think we need to override computeShape: (line 52351)
/**
* Compute the geometry for the template using its document data.
* Subclasses can override this method to take control over how different shapes are rendered.
* @returns {PIXI.Circle|PIXI.Rectangle|PIXI.Polygon}
* @protected
*/
_computeShape() {
let {angle, width, t} = this.document;
const {angle: direction, distance} = this.ray;
width *= canvas.dimensions.distancePixels;
switch ( t ) {
case "circle":
return MeasuredTemplate.#getCircleShape(distance);
case "cone":
return MeasuredTemplate.#getConeShape(direction, angle, distance);
case "rect":
return MeasuredTemplate.#getRectShape(direction, distance);
case "ray":
return MeasuredTemplate.#getRayShape(direction, distance, width);
}
}
from dnd4ebeta.
So I tried putting an override of computeShape in our override of the shape class, but was not able to fix the issue.
from dnd4ebeta.
I was able to fix the issue by wrapping computeShape
, and more or less combining it with the old getCircleShape
into a single if slightly messier method. Currently thrown into the v11 branch.
from dnd4ebeta.
Related Issues (20)
- EoUNT duration appears to be ending at SoUNT instead HOT 3
- [wishlist] Add secondary vulnerability and resistance attribute keys to implement 4e stacking rules HOT 1
- Unable to set base Fortitude for NPC HOT 2
- Past skill training checks are gone, past values are untogglable HOT 5
- [bug] Actor bloodied properties/variables acting screwy HOT 1
- [Bug] New Effect Application Timings not working for players HOT 1
- [Discussion] Modal power handling HOT 9
- [Request] Shield Bonus as defence modifier HOT 1
- [Clarification Request] Bonus dice as modifier HOT 1
- NPC Sheet Damage Bonus Issue HOT 1
- [Bug] Power Card Headers and coloring HOT 2
- [Request] Triggerless Effect HOT 1
- [Proposal] Additional bonus keys
- Some "weapons" shouldn't require a hand setting HOT 1
- [Wishlist] "Quarter damage" context menu action
- [Wishlist] Area, close, melee, ranged damage types & resistances, and ½ damage resistances HOT 1
- Can't Edit Damage Resistance HOT 1
- [Request] Money sum (value in gold) HOT 1
- New NPC Powers all fall under "Other" HOT 4
- No "Shadow" keyword HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dnd4ebeta.