Giter VIP home page Giter VIP logo

Comments (3)

draconas1 avatar draconas1 commented on September 10, 2024

https://github.com/tc39/proposal-class-fields/blob/main/PRIVATE_SYNTAX_FAQ.md

Foundy.js line 52402

  static #getCircleShape(distance) {
    return new PIXI.Circle(0, 0, distance);
  }

Think they have gone a bit more miliant with stopping us overriding!

I think we need to override computeShape: (line 52351)

  /**
   * Compute the geometry for the template using its document data.
   * Subclasses can override this method to take control over how different shapes are rendered.
   * @returns {PIXI.Circle|PIXI.Rectangle|PIXI.Polygon}
   * @protected
   */
  _computeShape() {
    let {angle, width, t} = this.document;
    const {angle: direction, distance} = this.ray;
    width *= canvas.dimensions.distancePixels;
    switch ( t ) {
      case "circle":
        return MeasuredTemplate.#getCircleShape(distance);
      case "cone":
        return MeasuredTemplate.#getConeShape(direction, angle, distance);
      case "rect":
        return MeasuredTemplate.#getRectShape(direction, distance);
      case "ray":
        return MeasuredTemplate.#getRayShape(direction, distance, width);
    }
  }

from dnd4ebeta.

draconas1 avatar draconas1 commented on September 10, 2024

So I tried putting an override of computeShape in our override of the shape class, but was not able to fix the issue.

from dnd4ebeta.

EndlesNights avatar EndlesNights commented on September 10, 2024

I was able to fix the issue by wrapping computeShape, and more or less combining it with the old getCircleShape into a single if slightly messier method. Currently thrown into the v11 branch.

from dnd4ebeta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.