how to debug? about graphql-ws HOT 5 CLOSED

Adding a good, versatile, logging system is not a straight forward task, you have to keep the following in mind:

• Use console.log?
  • Not versatile. Can pollute the console with mixed logs. Not in sync with a potential custom logging system (which almost every GQL server offers). Has to be disabled/enabled.
• Pass in a custom logger?
  • Have to "pollute" the lib by injecting the logger calls in various locations. Never-ending task - you have to rely on the lib itself to add support for the logs you want to add.

Having the reasoning above in mind, I'd like to avoid logging from within the lib. This lib is intended to be another tool in your tool-belt, meaning - you have to provide your own logging implementation on top of the lib. Please do argument your standpoint if you think my reasoning is off, I am indeed open for discussion.

Furthermore, not integrating a logger does not mean that you cannot extend the lib to log all the details you have requested! Please consult the "ws server usage with console logging" recipe.

from graphql-ws.

@enisdenjo I guess your snippet would be a nice addition to the recipe section?

from graphql-ws.

Please re-open this issue (or open a new one) if you think that the server usage with console logging recipe in the readme is lacking or you want to discuss my statement on internal logging from the comment above.

from graphql-ws.

I also agree! Having a snippet in the README for getting started would be awesome! People can then adjust it to their own needs as they wish.

from graphql-ws.

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from graphql-ws.