Comments (16)
enkiv2
commented on July 30, 2024
2
As of 5c0110d, if you set your BROWSER environment variable to w3m -o auto_image=TRUE, pressing g will open the currently selected message in w3m with images loaded.
It also respects the value of $PAGER if $BROWSER isn't set, and falls back to $VISUAL, then $EDITOR, then less.
If $BROWSER is set, it sends HTML, otherwise it sends plain text to the pager.
from fern.
enkiv2
commented on July 30, 2024
1
Alright, in cases where media attachments exist but are not linked to in the content, the pager now gets generated HTML for embedding them as of commit cb55138
This will double up any embeds that are actually linked in the content.
from fern.
enkiv2
commented on July 30, 2024
I don't plan to add image support in mainline fern. It'd add dependencies & complications.
That said, I might add support for configurable pagers (in order to deal with situations like posts from instances with long upper limits inside small terminals -- the message window does not scroll & I'm not planning to add scroll support to it), & if I do that, setting pager to w3m with image support turned on will let you view images.
from fern.
enkiv2
commented on July 30, 2024
THAT SAID -- if you want to submit a pull request, & can make the diff small & behavior degrade gracefully in the case that the dependency is missing (i.e., inserting a couple lines into message rendering & a couple lines up top for an import, where normal behavior remains if w3mimgdisplay python bindings aren't already installed) I'll merge it.
My policy is basically that fern code should remain a single file, no more than 1000 lines, & depend on nothing but Mastodon.py, no matter what features are added.
from fern.
shellkr
commented on July 30, 2024
I was expecting you wouldn't like it but thought I at least could ask. Your suggested solution would be great. A SNS like Mastodon do use a lot of media so having a way to view it would be a great addition.
Fri Jun 14 15:15:32 GMT+02:00 2019 John Ohno <[email protected]>:
…
THAT SAID -- if you want to submit a pull request, & can make the diff small & behavior degrade gracefully in the case that the dependency is missing (i.e., inserting a couple lines into message rendering & a couple lines up top for an import, where normal behavior remains if w3mimgdisplay python bindings aren't already installed) I'll merge it.
My policy is basically that fern code should remain a single file, no more than 1000 lines, & depend on nothing but Mastodon.py, no matter what features are added.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [#4?email_source=notifications&email_token=AAGMQJAFMBBXW6BY22WDCCLP2OKXJA5CNFSM4HX67Z7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWYHIA#issuecomment-502104992] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AAGMQJHVL2DJ6BUEY2THB23P2OKXJANCNFSM4HX67Z7A] . [https://github.com/notifications/beacon/AAGMQJCZZICRTZHMBCZLEELP2OKXJA5CNFSM4HX67Z7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWYHIA.gif]
from fern.
shellkr
commented on July 30, 2024
I just tried this and it almost worked as it should. The issue is that it does not open w3m $url but instead parses and sends the content of a post. Which means you will just get a long line of text in w3m and no images.
I hacked a bit but was little difficult when I am not familiar with the variables... but something like this works. From line 453.
if browser!="":
subprocessRun(browser+" "+tl[tlIdx]["url"])
This will not open the post but the whole thread. Didn't figure out how to open just the post.
from fern.
enkiv2
commented on July 30, 2024
Hmm...
W3m ought to be able to recognize the input as html. Sending the url will
probably mean that private posts (ex. DMs) can't be displayed. I'll take
another look.
To be clear, you set BROWSER=w3m and not PAGER=w3m, right?
…On Sun, Jun 23, 2019, 1:46 PM Shellkr ***@***.***> wrote:
I just tried this and it almost worked as it should. The issue is that it
does not open w3m $url but instead parses and sends the content of a
post. Which means you will just get a long line of text in w3m and no
images.
I hacked a bit but was little difficult when I am not familiar with the
variables... but something like this works. From line 453.
subprocessRun(browser+" "+tl[tlIdx]["url"])
This will not open the post but the whole thread. Didn't figure out how to
open just the post.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AADXUGMPXXDISFLU354FXVDP36ZIXA5CNFSM4HX67Z7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYLDREA#issuecomment-504772752>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADXUGOX6RA2H7KADMRJY33P36ZIXANCNFSM4HX67Z7A>
.
from fern.
shellkr
commented on July 30, 2024
Yes, BROWSER=w3m as you instructed. I will take another look later. Maybe w3m goes into pager mode somehow. Need to go to work now though.
from fern.
enkiv2
commented on July 30, 2024
It looks like w3m sometimes can't identify the input as HTML, so you'll have to add -T text/html to BROWSER.
My copy of w3m doesn't seem to be built with image support, so I can't verify that images are showing.
from fern.
shellkr
commented on July 30, 2024
Yeah, that makes it render but still does not show the images. I don't know if it is just me but I can not see a url to the image, just the "content" part. I can see the image url in fern but not after in w3m. Perhaps the url to the image is not sent to w3m?
from fern.
enkiv2
commented on July 30, 2024
I think w3m is ignoring the hint to render images. The URL is indeed sent
(as you can see by setting BROWSER=less and reading the HTML -- it's even a
fully-qualified URL). I don't use w3m's image support often enough to be
able to debug it (and back when I used it, I found it often sort of
randomly dropped images or put them in the wrong place anyway), but I think
this now comes down to making w3m display the image elements properly (by
hinting on the command line or something) -- not the sort of thing that
fern code should be doing.
…On Tue, Jun 25, 2019 at 2:39 AM Shellkr ***@***.***> wrote:
Yeah, that makes it render but still does not show the images. I don't
know if it is just me but I can not see a url to the image, just the
"content" part. I can see the image url in fern but not after in w3m.
Perhaps the url to the image is not sent to w3m?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AADXUGJ7YV5UENOBSV4G5B3P4G4SFA5CNFSM4HX67Z7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYPGFFY#issuecomment-505307799>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADXUGJ7DRZGZOBO7DKBNQTP4G4SFANCNFSM4HX67Z7A>
.
from fern.
shellkr
commented on July 30, 2024
Well, actually.. this is what BROWSER=less gives me on this. No image url is forwarded.
less output:
<html><body><p><a href="https://mstdn.io/tags/boris" class="mention hashtag" rel="tag">#<span>Boris</span></a> <a href="https://mstdn.io/tags/bus" class="mention hashtag" rel="tag">#<span>bus</span></a></p></body></html>
less output:
<html><body><p><span class="h-card"><a href="https://playvicious.social/@paeneultima" class="u-url mention" rel="nofollow noopener" target="_blank">@<span>paeneultima</span></a></span> This is what upset them</p></body></html>from fern.
enkiv2
commented on July 30, 2024
That is very strange. The original post had an image in it? I certainly
didn't strip it...
…On Tue, Jun 25, 2019 at 3:58 PM Shellkr ***@***.***> wrote:
Well, actually.. this is what BROWSER=less gives me on this. No image url
is forwarded.
[image: scrot_20190625-214905_662x118]
<https://user-images.githubusercontent.com/837668/60128651-6a3ed480-9793-11e9-8e70-49bf67d09485.png>
less output:
<html><body><p><a href="https://mstdn.io/tags/boris" class="mention hashtag" rel="tag">#<span>Boris</span></a> <a href="https://mstdn.io/tags/bus" class="mention hashtag" rel="tag">#<span>bus</span></a></p></body></html>
[image: scrot_20190625-215335_621x130]
<https://user-images.githubusercontent.com/837668/60128844-e6391c80-9793-11e9-8f9f-223fb8ba47bd.png>
less output:
<html><body><p><span class="h-card"><a ***@***.***" class="u-url mention" rel="nofollow noopener" target="_blank">@<span>paeneultima</span></a></span> This is what upset them</p></body></html>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AADXUGPWBHJSWZH6HI32XCTP4J2FHA5CNFSM4HX67Z7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYRNJOI#issuecomment-505599161>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADXUGJTEYUKJTGZAZIWSKLP4J2FHANCNFSM4HX67Z7A>
.
from fern.
shellkr
commented on July 30, 2024
Yes, as you can see in the image it had image url's that didn't get through to less. Only the text part got through. I have investigated a bit and according to https://mastodonpy.readthedocs.io/en/stable/ you have 'content' but also a 'media_attachments' for media attached in the toot.
from fern.
enkiv2
commented on July 30, 2024
You're right -- I don't process media_attachments, so anything that has a
media attachment that isn't present in the toot content is not visible in
the pager. (I can't remember if I even process that for text-only toot
display!) I'll take a look at processing that today, & see whether or not
doing so can be made straightforward (since media attachments theoretically
can be of an arbitrary media type, not just images.)
…On Tue, Jun 25, 2019 at 7:07 PM Shellkr ***@***.***> wrote:
Yes, as you can see in the image it had image url's that didn't get
through to less. Only the text part got through. I have investigated a bit
and according to https://mastodonpy.readthedocs.io/en/stable/ you have
'content' but also a 'media_attachments' for media attached in the toot.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AADXUGKAAQHI2XR5ZDQ3753P4KQM7A5CNFSM4HX67Z7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYR26FI#issuecomment-505655061>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADXUGJOCFNWBC7TDIGUZETP4KQM7ANCNFSM4HX67Z7A>
.
from fern.
shellkr
commented on July 30, 2024
That did it! Now it works as it should... and btw... I packaged it up and put it out on the AUR.
from fern.
Related Issues (3)
- Error after logging in HOT 6
- Jump to Oldest Unread HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fern.