Giter VIP home page Giter VIP logo

Comments (6)

ldruschk avatar ldruschk commented on August 26, 2024

Upon closer inspection the scoreboard doesn't adhere to the specification at all. The way it is currently implemented seems fine, but it is missing the FirstBlood information.

Also the numerical ServiceStatus isn't documented anywhere.

from enoengine.

mauricesvp avatar mauricesvp commented on August 26, 2024

Do you mean the old scoreboard? That is to be expected since we changed the specs just now while not changing the old scoreboard at all.

Also ServiceStatus is an enum

from enoengine.

ldruschk avatar ldruschk commented on August 26, 2024

@Trolldemorted told me I had to look at the /services/data/scoreboard.json files, are those not the correct ones?

from enoengine.

Trolldemorted avatar Trolldemorted commented on August 26, 2024

Those are the correct ones, they just don't match the spec

from enoengine.

ldruschk avatar ldruschk commented on August 26, 2024

Also ServiceStatus is an enum

Even then it would still be nice to have it documented where the Scoreboard API is

from enoengine.

ldruschk avatar ldruschk commented on August 26, 2024

Or simply pass it along as a string so changes in the order of the enum declaration don't cause issues

from enoengine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.