Giter VIP home page Giter VIP logo

Comments (3)

EnricoMi avatar EnricoMi commented on June 9, 2024

I think the issue here is that workflow Analyze Test Results runs after Validate workflow completed running on branch 3.x:

on:
  workflow_run:
    workflows: [Validate]
    types:
      - completed
    branches:
      - '3.x'

Your Validate workflow runs for push events on 3.x and pull_request events that target 3.x:

on:
  push:
    branches:
      - 3.x
  pull_request:
    branches:
      - 3.x

But pull_request events that target 3.x actually run on the branch of the respective PR, so they never trigger Validate for commits in a PR's branch, only push events do, when a PR is merged into 3.x.

I recommend you remove

    branches:
      - '3.x'

from the Analyze Test Results workflow.

from publish-unit-test-result-action.

EnricoMi avatar EnricoMi commented on June 9, 2024

For instance, pull request #1872 from mghpcsim:3.x targeting 3.x triggered the Analyze Test Results workflow, as the pull_request event runs on branch 3.x (of the fork): https://github.com/openhpc/ohpc/actions/runs/6236154747 triggering https://github.com/openhpc/ohpc/actions/runs/6236354221.

Any PR with a branch other than 3.x does not trigger the Analyze Test Results workflow.

from publish-unit-test-result-action.

adrianreber avatar adrianreber commented on June 9, 2024

Thanks. That makes sense and of course was the problem.

The goal from the line was to only run the analysis if the pull request was opened against the 3.x branch and not if the remote branch is named 3.x.

If I remember it correctly the way publish-unit-test-results works for pull request from forked projects was that we need a job on the default branch that triggers when all tests have finished and the results have been uploaded.

We are running CI also on non default branches and did not want to have failures in the "Actions" tab because a PR against the non default branch was running.

Anyway, we are good. Thanks for taking a look at this.

from publish-unit-test-result-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.