The Unit Test Results action is failing if there is a test failure about publish-unit-test-result-action HOT 9 CLOSED

You are right, there are use-cases where you want it to succeed and not pollute your checks. More flexibility over the default behaviour is a good compromise in this case.

Do you want to update your PR or should I sketch it out as it would require README.md and action.yml changes as well?

from publish-unit-test-result-action.

I will prepare something tomorrow then.

from publish-unit-test-result-action.

Please try the fix by running the action from branch branch-check-fail-behaviour:

uses: EnricoMi/publish-unit-test-result-action@branch-check-fail-behaviour

from publish-unit-test-result-action.

The quoted This action does not fail … refers to the actual publish job (publish_unit_test_results), which is green in both your screenshots. The check run that you are referring to is created by that action to summarize the test results.

To be honest I am not quite sure what is the best behaviour here. One could argue that the Unit Test Results check could represent the outcome of the unit tests and thus should reflect the failure, while the publish_unit_test_result is always green unless there is an exception in processing test results.

On the other hand you could say that the job that ran the unit tests should also fail, thus it is redundant for Unit Test Results to also be in fail state.

Unless there is a good reasoning for the latter point, I think I am shifted towards the first. In that case, I should probably reword that note to be more precise.

from publish-unit-test-result-action.

The current functionality is rigid and cannot satisfy a use-case where we want certain test failures to be notified on, but not actually cause a failure in the workflow.

What do you think about a boolean parameter for failOnFailedTests defaulting to true instead of forcing a specific behavior?

from publish-unit-test-result-action.

If you'd prefer to take the task I'd support that. Otherwise I could work on it on the weekend.

from publish-unit-test-result-action.

works great. thanks!

from publish-unit-test-result-action.

Merged to master. This will be released shortly.

from publish-unit-test-result-action.

This has been released. If you are using @v1, it should be picked up on the next run, otherwise upgrade to @v1.10 or @v1.

from publish-unit-test-result-action.