Giter VIP home page Giter VIP logo

Comments (14)

sylwiabr avatar sylwiabr commented on June 7, 2024 1

maybe describe method should be for whole Dataframe and describeColumn sholud take columnName and do what current describe does? @piotrMocz @kustosz ?

from dataframes.

mwu-tow avatar mwu-tow commented on June 7, 2024

Case: user has a table, wants to fill nulls in each column with a mean value for that column

from dataframes.

piotrMocz avatar piotrMocz commented on June 7, 2024

The thing I have very strong feelings about:
the Table class should expose the read<Format> method. Please keep in mind that we're not targetting expert programmers or even hobbyist programmers, but "data profesionals".

Table.readCSV is a method that gives you a table from a CSV file. Table.readXLS is a method that gives you a table from an Excel file. And so on. Accidentally, this is exactly how pandas does it. Advantages:

  • single import for Table read and for Table processing
  • "ideological" compatibility with pandas
  • hides the implementation details and makes the API dead simple

Currently you write CSVParser.readFile. Let's look at the drawbacks:

  • when processing data, you need another entity: some parser. I wouldn't want to have to know about some parsers when all I want to do is to read a dataframe from file
  • one more concept to keep track of
  • one more import

All in all, I suggest we at least add the Table.readCSV = CSVParser.readFile alias.

Like, really, please 😅

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

All non-user facing functions should have _ prefix

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

@piotrMocz what do you rthink about #57 in context of reading/writing files?

from dataframes.

wdanilo avatar wdanilo commented on June 7, 2024

Moreover, the toInt method should be named toEnum

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

Table.fromFile should have better name (more descriptive)

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

removeColumn -> removeByIndex

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

keep as opposite to remove

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

corr -> correlations
corrWith -> correlationsWith

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

change generated names from CORR_WITH_foo to corr_with_foo

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

sort -> sortMultiple
sort Descending by default
sort config (?)

from dataframes.

piotrMocz avatar piotrMocz commented on June 7, 2024

@piotrMocz what do you rthink about #57 in context of reading/writing files?

I left a comment there ;)

from dataframes.

sylwiabr avatar sylwiabr commented on June 7, 2024

plotVerticalLayout [Plot] - to remove when lazy vis appears

from dataframes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.