Cannot access "non-node" arguments in drop down widgets evaluation about enso HOT 9 CLOSED

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-21):

Progress: - playing with `Widget: #9941

• addressing review comments: #9997 (comment)
• perf issues: #9236 (comment)
• reporting PoC LS as library: #10010
• planning work & meeting & standup It should be finished by 2024-05-28.

from enso.

I've created a small project to play with the drop down arguments. Download as AccessArgumentsDropDown.zip and unzip. The code in question is:

from Standard.Base import all
from Standard.Base.Metadata import all
import Standard.Visualization

type T
    @b for_b
    as_list a b = [a, b]

for_b s cache=Nothing =
    me = [ "self", s ]
    a = ["a", cache "a"]
    b = ["b", cache "b"]
    make [1, "dva", me, a, b]

make values:Vector =
    make_option value = Choice.Option value.to_text value.pretty
    dbg values.to_text
    Widget.Single_Choice (values.map make_option) Nothing Display.Always

main =


    integer1 = 11
    node1 = T.as_list 436 1
    [node1, _]

foreign js dbg info = """
    debugger;

The first thing to notice is that evaluation of the @b widget content happens at UUID 83b40fc8-1b02-418e-8e0d-80f153bc2504 (index 496, size 9) which represents T.as_list - however when this node is evaluated, its arguments 436 and 1 aren't yet computed. There is also d872a8e8-47ea-4c0c-b3ef-a20df2ab4c3b which represents the whole T.as_list 436 1. If we want the drop down visualization to access the arguments, shouldn't we evaluate the visualization for the whole expression, @Frizi and @farmaazon?

from enso.

@jdunkerley, @marthasharkey - if you want to experiment with accessing arguments like 436, try it with this patch:

diff --git engine/runtime-instrument-common/src/main/java/org/enso/interpreter/instrument/RuntimeCache.java engine/runtime-instrument-common/src/main/java/org/enso/interpreter/instrument/RuntimeCache.java
index da2f8e2447..985a02d943 100644
--- engine/runtime-instrument-common/src/main/java/org/enso/interpreter/instrument/RuntimeCache.java
+++ engine/runtime-instrument-common/src/main/java/org/enso/interpreter/instrument/RuntimeCache.java
@@ -38,14 +38,8 @@ public final class RuntimeCache implements java.util.function.Function<String, O
       valuesToKeys.put(value, key);
       return true;
     } else {
-      var otherId = valuesToKeys.get(value);
-      var otherValue = cache.get(otherId);
-      if (otherValue != null && otherValue.get() == value) {
-        // if the value is already cached for another UUID, cache it
-        // for this expression UUID as well
-        var ref = new WeakReference<>(value);
-        expressions.put(key, ref);
-      }
+      var ref = new WeakReference<>(value);
+      expressions.put(key, ref);
       return false;
     }
   }

it does seem to work to some extend (values may be outdated, or missing from time to time). It should be good enough for testing.

from enso.

The first thing to notice is that evaluation of the @b widget content happens at UUID 83b40fc8-1b02-418e-8e0d-80f153bc2504 (index 496, size 9) which represents T.as_list

By evaluation you mean on what value get_widget_json is called? Then it's even stranger, because according to our code it should be called on self argument, that is T in this case.

from enso.

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-22):

Progress: - small Widget repro: https://discord.com/channels/@me/948519891961544714/1242708122607550464

• design evaluation for widgets: #9941 (comment)
• addressing review comments: #9997
• review of Hubert's: #9914 (review)
• meeting Pavel
• meeting James: rewrite table representation (to Truffle?)
• reacting to comments: aaa5e9e It should be finished by 2024-05-28.

Discord

Discord - A New Way to Chat with Friends & Communities

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

from enso.

The first thing to notice is that evaluation of the @b widget content happens at UUID 83b40fc8-1b02-418e-8e0d-80f153bc2504 (index 496, size 9) which represents T.as_list

By evaluation you mean on what value get_widget_json is called?

Yes. get_widget_json calls into @b annotation.

Then it's even stranger, because according to our code it should be called on self argument, that is T in this case.

You are right the [{"index":{"value":496},"size":{"value":1}},"83b40fc8-1b02-418e-8e0d-80f153bc2504"] node represents T - I misread the location due to strange formatting of the metadata in my text editor.

from enso.

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-23):

Progress: - ms in log merged : #10016

• Enso Library Feature merged: #9997
• reporting subsequent work: #10044
• widgets discussion with Pawel & Hubert & at standup
• "storage benchmark" proposal: #10056 It should be finished by 2024-05-28.

from enso.

Jaroslav Tulach reports a new STANDUP for the last Friday (2024-05-24):

Progress: - reactive RuntimeCache PR: #10065

• debugging and recording video: #10065 (comment)
• reviewing persistance fixes by Radek: https://discord.com/channels/@me/964018046375190528/1243541832156319896
• planning, standups It should be finished by 2024-05-28.

Discord

Discord - A New Way to Chat with Friends & Communities

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

from enso.

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-27):

Progress: - Reactive Cache is in: #10065

• pesistance fix: https://discord.com/channels/@me/964018046375190528/1244553530661015622
• review, not really in favor of attach-debugger: #10062 (review)
• ModuleScope.Builder note: https://github.com/enso-org/enso/pull/9914/files#r1615844358
• review private method: #10060 (review)
• debugging suspended default arguments: #8937 (comment) It should be finished by 2024-05-28.

Discord

Discord - A New Way to Chat with Friends & Communities

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

GitHub

WIP: Extract mutable builder from `ModuleScope` by hubertp · Pull Request #9914 · enso-org/enso

Pull Request Description Refactored mutable parts of ModuleScope into builder to make it easier to reduce unnecessary locks. Important Notes

Checklist
Please ensure that the following checklist ha...

from enso.