Comments (9)
All seems to be working fine now :). Please close.
from angular-universal.
does not work: loadChildren: () => import('./modules/container.modules/home.container.module/home.container.module').then(m => m.HomeContainerModule)
works: loadChildren: './modules/container.modules/home.container.module/home.container.module#HomeContainerModule'
from angular-universal.
Did you update to angular 8?
Because it's a new feature (check angular realease 8 blog post).
from angular-universal.
Yes what I mean is that when LoadChildren uses the new dynamic import syntax the module is not lazy loaded but is included in the main module. For example the welcome module in the starter kit is not lazy loaded any more.
from angular-universal.
When I compile the same code (dynamic imports) without the UDK several modules are created (both for ES2015 and ES5). When I compile with the UDK I get one big main.js file. If I donβt use the dynamic imports I get modules but not two separate ones for es5/es2015. Also they are a lot larger than the ones made by the angular compiler without UDK.
from angular-universal.
@christostatitzikidis
My bad. I made a mistake in the workspace tsconfig.json.
I will push a commit to fix that.
diff --git a/tsconfig.json b/tsconfig.json
index ef44e28..607415f 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -5,10 +5,11 @@
"outDir": "./dist/out-tsc",
"sourceMap": true,
"declaration": false,
+ "module": "esnext",
"moduleResolution": "node",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
- "target": "es5",
+ "target": "es2015",
"typeRoots": [
"node_modules/@types"
],
from angular-universal.
@christostatitzikidis
Can you try to fetch update or apply the patch and tells us if lazy route as import works again?
from angular-universal.
Yes, it works on this repository :) thanks! I'll try it tomorrow at work on the project I'm working on (40+ lazy loaded modules) and let you know if I find any other issues. Good job and thanks btw, been using this for a good while and now it seems to be even better with supporting HRM on lazy routes. Thanks again for the quick response and fix!
from angular-universal.
40+ lazy loaded modules
Waw! And everything building in the same universal compilation?
I'm waiting that you test at your work before close this issue :)
from angular-universal.
Related Issues (20)
- [question] now.sh deployment HOT 4
- window is not defined AND localStorage is not defined errors in terminal HOT 10
- How to keep state across module reloads HOT 2
- Could not find the implementation for builder udk:udk-builder HOT 4
- typo in udk.container.js
- npm start has 'SyntaxError: Unexpected string' on main.server.ts HOT 4
- HMR not working correctly - entire app reloads on change HOT 4
- Does HMR only replace module HOT 4
- changes are not reflected in server build HOT 3
- TransferStateModule not being used HOT 3
- What is the difference between this repo and angular/universal-starter ? HOT 2
- error with current build HOT 5
- Does this project offer HMR and SSR simultaneously? HOT 4
- Error with latest master HOT 3
- Support for Angular 11 HOT 6
- assets folder is not copied to dist/app/browser HOT 2
- lazy load module not working in server side HOT 4
- What happened with the commit history? HOT 3
- Can't bind to 'errorImage' since it isn't a known property of 'img'. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-universal.