Giter VIP home page Giter VIP logo

Comments (10)

murphy85 avatar murphy85 commented on June 2, 2024 1

Here are the other buttons:

envoy-website/index.html

Lines 112 to 115 in 93f28a3

<div class="action-btns text-center">
<a href="https://www.envoyproxy.io/docs/envoy/latest/" class="btn-legacy btn-primary">Get Started</a>
<a href="https://www.envoyproxy.io/docs/envoy/latest/start/install" class="btn-legacy btn-secondary">Download</a>
</div>

Maybe just copy them

from envoy-website.

phlax avatar phlax commented on June 2, 2024

thanks for raising this @murphy85 - that button/link is wrong on quite a few levels 8/

if you fancy PRing to fix im happy to review, otherwise i will look at this asap

from envoy-website.

murphy85 avatar murphy85 commented on June 2, 2024

Hi, thank you!
Unfortunately I couldn't find the source code of the envoyproxy website in git and didn't found "install/building" within a file in git.

from envoy-website.

phlax avatar phlax commented on June 2, 2024

the docs are stored in envoy itself - but the buttons that you posted above are rendered from this repository

from envoy-website.

phlax avatar phlax commented on June 2, 2024

see here for buttons

envoy-website/index.html

Lines 20 to 23 in 93f28a3

<div class="action-btns text-center">
<a href="https://www.envoyproxy.io/docs/envoy/latest/start/start" class="btn-legacy btn-primary">Get Started</a>
<a href="https://www.envoyproxy.io/docs/envoy/latest/install/building" class="btn-legacy btn-secondary">Download</a>
</div>

not sure exactly the best fix - i think download should not be pointing to the building page in the docs - i think that was the case for legacy reasons and i think the link is gone/moved now

from envoy-website.

phlax avatar phlax commented on June 2, 2024

probably pointing to the latest release on github

from envoy-website.

murphy85 avatar murphy85 commented on June 2, 2024

Probably using the same link for both, because the buttons look the same and have the same description and are both next to Get started?
But it's up to you which url you want to use :-)

from envoy-website.

ishaanbahal avatar ishaanbahal commented on June 2, 2024

Don't know if the fix above is right or wrong, but at least the link at the bottom goes somewhere, wanted to download envoy, the 404 doesn't look great for such an amazing project.

Ref: #305

from envoy-website.

phlax avatar phlax commented on June 2, 2024

hi @ishaanbahal it needs to be fixed in the envoy repo

apologies that was wrong - checking your fix now

i thought we had done this already if you want to PR there i can help otherwise i can clear this up

from envoy-website.

phlax avatar phlax commented on June 2, 2024

fixed in #305

from envoy-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.