Giter VIP home page Giter VIP logo

Comments (4)

mattklein123 avatar mattklein123 commented on July 24, 2024

Right now we only have a retry policy which includes all 5xx (all resets before headers result in a 5xx). We can definitely add a retry policy just for certain reset types (including REFUSED_STREAM):
https://github.com/lyft/envoy/blob/master/source/common/router/retry_state_impl.cc#L81

from envoy.

louiscryan avatar louiscryan commented on July 24, 2024

All 5xx seems a little dangerous? Internal Server Error & Gateway Timeout leave plenty of scope for the call to have had some effect on state.

from envoy.

mattklein123 avatar mattklein123 commented on July 24, 2024

We don't do any retries by default (mainly because of idempotency concerns per your point). The retry policies are configurable on a per route and per request basis. See here:
https://lyft.github.io/envoy/docs/configuration/http_filters/router_filter.html#x-envoy-retry-on
https://lyft.github.io/envoy/docs/configuration/http_conn_man/route_config/route.html#config-http-conn-man-route-table-route-retry

We do have many people who want the "5xx" policy since they know that the calls they are making are idempotent. At Lyft we also use the "connect-failure" policy almost everywhere since that is guaranteed to be idempotent.

It is very easy to add a new policy and we can definitely add one for a REFUSED_STREAM reset.

from envoy.

mattklein123 avatar mattklein123 commented on July 24, 2024

#74

from envoy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.