Giter VIP home page Giter VIP logo

Comments (4)

kyessenov avatar kyessenov commented on June 14, 2024

The reasoning for holding the request was that we would need to generate multiple intermediate versions for EDS responses. A simple example is that let's say we have two clusters C1 and C2, and envoy requests:

  1. EDS for {C1}
  2. EDS for {C1, C2}

If we respond to request 1 with version X, then we need a new version Y for request 2. Generating this intermediate versions is certainly possible, but what we have now would simply not respond to request 1, and instead respond to request 2 with version X. This allows a simpler versioning scheme for snapshots (e.g. just set the whole config snapshot to version X, and converge on all proxies being at version X).

from go-control-plane.

dfjones avatar dfjones commented on June 14, 2024

Thanks for the reply, @kyessenov.

The sequence you outlined makes sense to me. I'm wondering if you have any suggestions for how to avoid the deadlock issue I described above? IMO it seems a bit too coupled that our control plane and each Envoy instance have to be on the same page about what clusters are declared statically in the Envoy's config and which should be sent through CDS. As it stands right now, it feels a bit fragile.

from go-control-plane.

github-actions avatar github-actions commented on June 14, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

from go-control-plane.

github-actions avatar github-actions commented on June 14, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

from go-control-plane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.