Giter VIP home page Giter VIP logo

Comments (6)

RadEdje avatar RadEdje commented on May 21, 2024 1

Greetings,

Just wanted to congratulate you on this amazing python PINOY PSE lbrary.

Now for my question;

I imported the following:

from fastquant import get_company_disclosures

but got this error on google colab:

`ImportError Traceback (most recent call last)

in ()
----> 1 from fastquant import get_company_disclosures

ImportError: cannot import name 'get_company_disclosures'
`

I thought it could be a problem with the Kernel so I restarted, re-installed fastquant and re-ran all the python scripts but still couldn't import get_company_discolsures.....

Any suggestions would be highly appreciated. Thanks.

from fastquant.

jpdeleon avatar jpdeleon commented on May 21, 2024 1

Hi @RadEdje, thanks for checking fastquant. You have to first initialize the DisclosuresPSE class before being able to use the get_company_disclosures method. Please see the example in this notebook:

https://github.com/enzoampil/fastquant/blob/master/examples/disclosures.ipynb

from fastquant.

enzoampil avatar enzoampil commented on May 21, 2024

@jpdeleon
You basically read my mind on the next steps for that function. Figuring out the pattern w/ that URL is still a huge todo that could allow us to integrate a lot of NLP into psequant.

On how to scrape the company disclosures, my current impression (haven't stress tested this but have seen the patterns based on a few instances) is that each Template Name (w/ its own form number) will have a fairly similar html structure, so the current approach to adding functionality to scrape contents is if we go through each template one by one and create the scraping logic for each separately. Of course we can prioritize certain templates over others and start with those.

I'll prioritize this as the next feature to work on (probably w/ disclosures first), but also feel free to help out with a PR if you find a solution before I post an update :)

from fastquant.

enzoampil avatar enzoampil commented on May 21, 2024

@jpdeleon URL issue should be resolved now. get_company_disclosures() now returns a df with a url column that points to the url of the required doc :) Now the only thing left is to integrate scraping logic per disclosure type! (as indicated above).

from fastquant.

jpdeleon avatar jpdeleon commented on May 21, 2024

I pulled the changes and it worked! Inddeed, simply adding an url column in the df is the way to go.

from fastquant.

jpdeleon avatar jpdeleon commented on May 21, 2024

@RadEdje Did it work for you? Please give us some feedback for improvements or feature requests if there are any. Thanks!

from fastquant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.