Giter VIP home page Giter VIP logo

Comments (6)

seabbs avatar seabbs commented on August 20, 2024 2

Sorry yes, I missed that before. Done

from epinow2.

joeHickson avatar joeHickson commented on August 20, 2024 1

I have only put the timeout in the regional_epinow function which always returns a result set from the epinow call - this might mean we can sidestep the re-loading from disk issue.

from epinow2.

joeHickson avatar joeHickson commented on August 20, 2024

To give visibility of processes being killed this needs a mechanism to return the identity of any failures

from epinow2.

joeHickson avatar joeHickson commented on August 20, 2024

good news! Rstan does indeed seem to be killed and die.
bad news - funnily enough the summary processing doesn't handle missing data very well!

@seabbs do you have any feeling about how we should represent No Data Available / timeout in the estimate summary? I think the regional epinow route is using the out object to hold the data so it doesn't re-load from disk, and it also has the full list of locations in the region.

from epinow2.

seabbs avatar seabbs commented on August 20, 2024

That is great news and yes I can imagine.

So at the moment, the expectation is that when read in from the out object subregions that have failed will have NULL. These then get thrown away in regional_summary and everything continues as normal. When using regional_summary and reading in from disk I think it may be less fault-tolerant (with this bit of code:

estimates <- purrr::map(regions, ~ load_data(file = "summary.rds", region = .))
potentially being an issue but this bit:

EpiNow2/R/get.R

Line 113 in fafb618

load_data <- purrr::safely(EpiNow2::get_raw_result)
being fault-tolerant). Similarly, a NULL in the output indicates any failure.

Could continue this for subregions that have been timed out with an informative log entry or add a message to the out object/into the results folder but this would then add a bit of a headache for results processing.

When saving it would make sense to save a killed due to time-out flag definitely.

When outputting results (we stick with this duality, by the way, to stay being CRAN compliant + acting like a normal package whilst also supporting saving to folders in order to make producing regional results more independent) we could add another list entry on the top level to the out object. At the moment it has $regional and $summary. Could also add $timeout and list subregions that have been timed out (could do the same thing for regions that have errored). If going with this approach I guess it would make sense to save this information into the summary folder (though that adds complexity in passing objects into regional_summary whilst trying to maintain interoperability between reading in from disk and passing in objects).

Sorry - a bit of ramble - happy to clarify any of the above that is unclear.

from epinow2.

joeHickson avatar joeHickson commented on August 20, 2024

@seabbs Please could you add @JAllen42 so he can put a bit of work in on this? Thanks

from epinow2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.